Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: tests/compiler/dart2js/string_escapes_test.dart

Issue 336413002: Allow whitespace and \ before the first newline of multiline string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use more intuitive test. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/string_escapes_test.dart
diff --git a/tests/compiler/dart2js/string_escapes_test.dart b/tests/compiler/dart2js/string_escapes_test.dart
index f439689b8dbe6617d03b3225006130ce4ca089f2..a841ce12bdb9bdc68466c4a37bae85bddb03c192 100644
--- a/tests/compiler/dart2js/string_escapes_test.dart
+++ b/tests/compiler/dart2js/string_escapes_test.dart
@@ -17,10 +17,18 @@ Future<String> compileExpression(String expression) {
main() {
asyncTest(() => Future.wait([
compileExpression("''' \n\r\u2028\u2029'''").then((String generated) {
- Expect.isTrue(generated.contains(r"\n\r\u2028\u2029"));
+ Expect.isTrue(generated.contains(r"\r\u2028\u2029"));
}),
compileExpression("r''' \n\r\u2028\u2029'''").then((String generated) {
- Expect.isTrue(generated.contains(r"\n\r\u2028\u2029"));
+ Expect.isTrue(generated.contains(r"\r\u2028\u2029"));
Johnni Winther 2014/06/18 08:43:44 Add tests for \r, \n, \r\n adn \n\r.
Lasse Reichstein Nielsen 2014/06/18 09:05:32 .. where \n\r is not a line-terminator sequence, s
floitsch 2014/06/18 12:14:23 Done.
floitsch 2014/06/18 12:14:23 Done.
+ }),
+ compileExpression("r'''\t\t \t\t \t\t \t \t \n\r\u2028\u2029'''")
+ .then((String generated) {
+ Expect.isTrue(generated.contains(r"\r\u2028\u2029"));
+ }),
+ compileExpression("r'''\t\t \t\t \t\t \t \t \\\n\r\u2028\u2029'''")
+ .then((String generated) {
+ Expect.isTrue(generated.contains(r"\r\u2028\u2029"));
}),
Lasse Reichstein Nielsen 2014/06/17 15:56:52 Also test backslashes before other whitespace char
floitsch 2014/06/18 12:14:23 Not tested (and not being accepted): \\\r\\\n That
compileExpression("'\u2028\u2029'").then((String generated) {
Expect.isTrue(generated.contains(r"\u2028\u2029"));
« sdk/lib/_internal/compiler/implementation/tree/nodes.dart ('K') | « tests/co19/co19-dart2js.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698