Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 336403002: Add @@iterator, .entries(), .values(), .keys() support to typed arrays (Closed)

Created:
6 years, 6 months ago by wingo
Modified:
6 years, 6 months ago
CC:
v8-dev, arv (Not doing code reviews), Dmitry Lomov (no reviews)
Visibility:
Public.

Description

Add @@iterator, .entries(), .values(), .keys() support to typed arrays R=arv@chromium.org, rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21999

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
M src/array-iterator.js View 1 chunk +27 lines, -0 lines 1 comment Download
A test/mjsunit/harmony/typed-array-iterator.js View 1 chunk +41 lines, -0 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
Depends on the Array.prototype[Symbol.iterator] patch here: https://codereview.chromium.org/338323003/
6 years, 6 months ago (2014-06-17 14:15:52 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 6 months ago (2014-06-17 15:41:26 UTC) #2
rossberg
lgtm https://codereview.chromium.org/336403002/diff/1/src/array-iterator.js File src/array-iterator.js (right): https://codereview.chromium.org/336403002/diff/1/src/array-iterator.js#newcode150 src/array-iterator.js:150: %SetProperty(global.NAME.prototype, 'entries', ArrayEntries, DONT_ENUM); Why do you need. ...
6 years, 6 months ago (2014-06-18 09:38:02 UTC) #3
wingo
> https://codereview.chromium.org/336403002/diff/1/src/array-iterator.js#newcode150 > src/array-iterator.js:150: %SetProperty(global.NAME.prototype, 'entries', > ArrayEntries, DONT_ENUM); > Why do you need. 'global.' ...
6 years, 6 months ago (2014-06-25 07:52:01 UTC) #4
wingo
6 years, 6 months ago (2014-06-25 08:47:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r21999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698