Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 336393002: DevTools: quick fix for NetworkAgent.emulateNetworkConditions. (Closed)

Created:
6 years, 6 months ago by eustas
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: quick fix for NetworkAgent.emulateNetworkConditions. Recently protocol was changed, but invocation remained unchanged. BUG=245436 TBR=vsevik@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eustas
6 years, 6 months ago (2014-06-17 14:13:07 UTC) #1
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-17 14:13:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/336393002/1
6 years, 6 months ago (2014-06-17 14:14:09 UTC) #3
eustas
The CQ bit was unchecked by eustas@chromium.org
6 years, 6 months ago (2014-06-17 14:25:07 UTC) #4
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-17 14:25:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/336393002/1
6 years, 6 months ago (2014-06-17 14:25:32 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 14:40:52 UTC) #7
Message was sent while issue was closed.
Change committed as 176316

Powered by Google App Engine
This is Rietveld 408576698