Issue 336373002: Parametrize TimelinePresentationModel with coalescable record types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336373002: Parametrize TimelinePresentationModel with coalescable record types (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, alph, pfeldman, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Parametrize TimelinePresentationModel with coalescable record types This CL removes dependency on WebInspector.TimelineModel.RecordType as underlying implementation may use tracing events in which case coalescable types should be from WebInspector.TracingTimelineModel. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176306

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -13 lines)			Patch
M	Source/devtools/front_end/timeline/TimelinePanel.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePresentationModel.js	View	3 chunks	+4 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineView.js	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/336373002/1

6 years, 6 months ago (2014-06-17 09:45:27 UTC) #4

Message was sent while issue was closed.

Change committed as 176306

Expand Messages | Collapse Messages