LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js - Issue 336343002: Use "Dictionary" for PositionOptions instead of Custom binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js

Issue 336343002: Use "Dictionary" for PositionOptions instead of Custom binding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebasing for removing PerWorldBindings (http://crrev.com/330293002) Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Geolocation/not-enough-arguments-expected.txt ('k') | Source/bindings/v8/custom/V8GeolocationCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js

diff --git a/LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js b/LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js

index c35c5fb2a12e79ed01d08d324efda6bfa7cc28d9..6c007e9517248fea7636a72e927a33d2a103bb4f 100644

--- a/LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js

+++ b/LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js

@@ -64,11 +64,11 @@ test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, null)',

test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, {})', false);

test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, objectThrowingException)', true, 'Error: enableHighAccuracy getter exception');

test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, emptyFunction)', false);

-test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, true)', false);

-test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, 42)', false);

-test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, Infinity)', false);

-test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, -Infinity)', false);

-test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, "string")', false);

+test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, true)', true);

+test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, 42)', true);

+test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, Infinity)', true);

+test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, -Infinity)', true);

+test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, "string")', true);

test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, {dummyProperty:undefined})', false);

test('navigator.geolocation.getCurrentPosition(emptyFunction, undefined, {dummyProperty:null})', false);