Source/modules/geolocation/Geolocation.idl - Issue 336343002: Use "Dictionary" for PositionOptions instead of Custom binding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/Geolocation.idl

Issue 336343002: Use "Dictionary" for PositionOptions instead of Custom binding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/geolocation/Geolocation.cpp ('k') | Source/modules/geolocation/PositionOptions.h » ('j') | Source/modules/geolocation/PositionOptions.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/Geolocation.idl

diff --git a/Source/modules/geolocation/Geolocation.idl b/Source/modules/geolocation/Geolocation.idl

index 736e71579d68a35e7898ae08ff293bb394e96dfe..aa9e828e192102cc70150e43b351999613294599 100644

--- a/Source/modules/geolocation/Geolocation.idl

+++ b/Source/modules/geolocation/Geolocation.idl

@@ -29,14 +29,14 @@

NoInterfaceObject,

] interface Geolocation {

// FIXME: should be: PositionOptions options: need PositionOptions.idl and dictionary http:/crbug.com/321462

- [Custom, PerWorldBindings, LogActivity] void getCurrentPosition(PositionCallback successCallback,

+ [PerWorldBindings, LogActivity] void getCurrentPosition(PositionCallback successCallback,

optional PositionErrorCallback errorCallback,

- optional object options);

+ optional Dictionary options);

// FIXME: should be: PositionOptions options: need PositionOptions.idl and dictionary http:/crbug.com/321462

- [Custom, PerWorldBindings, LogActivity] long watchPosition(PositionCallback successCallback,

+ [PerWorldBindings, LogActivity] long watchPosition(PositionCallback successCallback,

optional PositionErrorCallback errorCallback,

- optional object options);

+ optional Dictionary options);

void clearWatch(long watchID);

};