Fixed the colour and layout logic of the App Info dialog heading

Fixed the colour and layout logic of the App Info dialog heading

Added a colour to the version number and updated the font size to better
match the mocks. Also fixed a small bug in the logic that lays out the
name and version to place the version number on the next line if there
are no links (no webstore or license links) for the app.

Based off CL 335523002.

BUG=385423, 383720
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278290

[sashab, 2014-06-17 02:40:56]

Small, low-priority CL.

[benwells, 2014-06-18 00:19:02]

lgtm

https://codereview.chromium.org/336333002/diff/1/chrome/browser/ui/views/apps...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
(right):

https://codereview.chromium.org/336333002/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc:49: const
int kSpacingBetweenAppTitleAndVersion = 4;
Nit: I recall seeing a few of constants like this. If they are all the same
constant but are in multiple panel files, they should instead go into
AppInfoPanel as static consts or into the app_list constants file as a dialog
constant.

[sashab, 2014-06-18 00:42:53]

Thanks ben!

https://codereview.chromium.org/336333002/diff/1/chrome/browser/ui/views/apps...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
(right):

https://codereview.chromium.org/336333002/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc:49: const
int kSpacingBetweenAppTitleAndVersion = 4;
On 2014/06/18 00:19:02, benwells wrote:
> Nit: I recall seeing a few of constants like this. If they are all the same
> constant but are in multiple panel files, they should instead go into
> AppInfoPanel as static consts or into the app_list constants file as a dialog
> constant.

Nope, none of them are the same :) And after the refactor this is the only file
with constants at the top like this :) I'll put them in an anonymous namespace
though, where they should be.

[sashab, 2014-06-18 22:14:44]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-06-18 22:15:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/336333002/20001

[commit-bot: I haz the power, 2014-06-19 06:50:58]

Change committed as 278290