Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 336313018: [Android] Move content/browser/{renderer_host => android}/java/* (Closed)

Created:
6 years, 5 months ago by mnaganov (inactive)
Modified:
6 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, benm (inactive)
Project:
chromium
Visibility:
Public.

Description

[Android] Move content/browser/{renderer_host => android}/java/* As jam@ has suggested here: https://codereview.chromium.org/353163002/#msg4 Java Bridge isn't used in renderer_host, thus content/browser/android/java is a better location. BUG=355644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280798

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated paths for unit tests, rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -5062 lines) Patch
M content/browser/android/browser_jni_registrar.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A content/browser/android/java/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/browser/android/java/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/android/java/gin_java_bound_object.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/android/java/gin_java_bound_object.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/android/java/gin_java_bound_object_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/android/java/gin_java_bound_object_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/android/java/gin_java_bridge_dispatcher_host.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/gin_java_method_invocation_helper.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/android/java/gin_java_method_invocation_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/android/java/gin_java_method_invocation_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/android/java/gin_java_script_to_java_types_coercion.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/android/java/gin_java_script_to_java_types_coercion.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/android/java/java_bound_object.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/android/java/java_bound_object.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/android/java/java_bridge_channel_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/java_bridge_channel_host.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/android/java/java_bridge_dispatcher_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/java_bridge_dispatcher_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/android/java/java_bridge_dispatcher_host_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/java_bridge_dispatcher_host_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/java_method.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/android/java/java_method.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/android/java/java_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/java_type.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/android/java/jni_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/android/java/jni_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/android/java/jni_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/java/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/browser/renderer_host/java/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_bound_object.h View 1 chunk +0 lines, -96 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_bound_object.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_bound_object_delegate.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_bound_object_delegate.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_bridge_dispatcher_host.h View 1 chunk +0 lines, -123 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_method_invocation_helper.h View 1 chunk +0 lines, -117 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_method_invocation_helper.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_method_invocation_helper_unittest.cc View 1 chunk +0 lines, -339 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_script_to_java_types_coercion.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/renderer_host/java/gin_java_script_to_java_types_coercion.cc View 1 chunk +0 lines, -705 lines 0 comments Download
D content/browser/renderer_host/java/java_bound_object.h View 1 chunk +0 lines, -96 lines 0 comments Download
D content/browser/renderer_host/java/java_bound_object.cc View 1 chunk +0 lines, -1040 lines 0 comments Download
D content/browser/renderer_host/java/java_bridge_channel_host.h View 1 chunk +0 lines, -52 lines 0 comments Download
D content/browser/renderer_host/java/java_bridge_channel_host.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D content/browser/renderer_host/java/java_bridge_dispatcher_host.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/browser/renderer_host/java/java_bridge_dispatcher_host.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h View 1 chunk +0 lines, -76 lines 0 comments Download
D content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D content/browser/renderer_host/java/java_method.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/renderer_host/java/java_method.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D content/browser/renderer_host/java/java_type.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/renderer_host/java/java_type.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D content/browser/renderer_host/java/jni_helper.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/browser/renderer_host/java/jni_helper.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D content/browser/renderer_host/java/jni_helper_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +24 lines, -24 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mnaganov (inactive)
https://codereview.chromium.org/336313018/diff/1/content/browser/android/java/DEPS File content/browser/android/java/DEPS (right): https://codereview.chromium.org/336313018/diff/1/content/browser/android/java/DEPS#newcode2 content/browser/android/java/DEPS:2: "+content/child", # For java bridge bindings Please note that ...
6 years, 5 months ago (2014-06-30 16:51:52 UTC) #1
jam
lgtm
6 years, 5 months ago (2014-06-30 22:05:02 UTC) #2
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 5 months ago (2014-07-01 07:50:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/336313018/20001
6 years, 5 months ago (2014-07-01 07:51:03 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 11:21:05 UTC) #5
Message was sent while issue was closed.
Change committed as 280798

Powered by Google App Engine
This is Rietveld 408576698