LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html - Issue 336313015: Remove the webkitallowfullscreen content attribute

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html

Issue 336313015: Remove the webkitallowfullscreen content attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fullscreen/full-screen-enabled-prefixed-expected.txt ('k') | LayoutTests/fullscreen/full-screen-iframe-allowed-nested-expected.txt » ('j') | LayoutTests/fullscreen/full-screen-iframe-zIndex.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <p>Test entering full screen for a nested iframe works with a mixture of both	1 <p>Test entering full screen for nested iframes.</p>
	falken 2014/07/01 05:03:28 nit: I guess as we're rewriting this we might as w nit: I guess as we're rewriting this we might as well clean it up. include <DOCTYPE>
2 allowfullscreen and webkitallowfullscreen.</p>

3 <p>To test manually, click into inner frame, the page should enter full screen m ode.</p>	2 <p>To test manually, click into inner frame, the page should enter full screen m ode.</p>

4 <script src="full-screen-test.js"></script>	3 <script src="full-screen-test.js"></script>

5 <iframe webkitallowfullscreen src="resources/full-screen-iframe-with-mixed-allow -webkitallow-iframe1.html">	4 <iframe allowfullscreen src="resources/full-screen-iframe-allowed-nested1.html">

6 </iframe>	5 </iframe>

7 <script>	6 <script>

8 window.onmessage = function () { // iframes have been loaded and messaged us.	7 window.onmessage = function () { // iframes have been loaded and messaged us.

9 // Send click to center of iframe.	8 // Send click to center of iframe.

10 iframe = document.getElementsByTagName("iframe")[0];	9 iframe = document.getElementsByTagName("iframe")[0];

11 x = iframe.offsetLeft + iframe.offsetWidth / 2;	10 x = iframe.offsetLeft + iframe.offsetWidth / 2;

12 y = iframe.offsetTop + iframe.offsetHeight / 2;	11 y = iframe.offsetTop + iframe.offsetHeight / 2;

13 if (window.eventSender) {	12 if (window.eventSender) {

14 eventSender.mouseMoveTo(x, y);	13 eventSender.mouseMoveTo(x, y);

15 eventSender.mouseDown();	14 eventSender.mouseDown();

16 eventSender.mouseUp();	15 eventSender.mouseUp();

17 }	16 }

18	17

19 window.onmessage = function (messageEvent) {	18 window.onmessage = function (messageEvent) {

20 consoleWrite(messageEvent.data);	19 consoleWrite(messageEvent.data);

21 endTest();	20 endTest();

22 }	21 }

23 }	22 }

24 </script>	23 </script>

25	24
	falken 2014/07/01 05:03:28 nit: extra newline nit: extra newline
OLD	NEW