Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336313015: Remove the webkitallowfullscreen content attribute (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, blink-reviews-html_chromium.org, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Remove the webkitallowfullscreen content attribute Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/LupOLlogL-g/H8GsBEDGQeMJ Tests were updated to use allowfullscreen instead of webkitallowfullscreen, with a few exceptions: fullscreen/full-screen-enabled-prefixed.html would have become redundant with fullscreen/full-screen-enabled.html and was removed. fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html became a test for nested iframes with allowfullscreen and was renamed. Finally, doctypes were added and whitespace cleaned up in touched test. fullscreen/resources/full-screen-iframe-allowed-nested2.html depended on being in quirks mode, since the size of the body element is smaller in standards mode. Put the click event handler on window instead. BUG=390008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177332

Patch Set 1 #

Total comments: 3

Patch Set 2 : test style #

Patch Set 3 : fix quirks mode test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -124 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fullscreen/exit-full-screen-iframe.html View 1 2 chunks +2 lines, -1 line 0 comments Download
D LayoutTests/fullscreen/full-screen-enabled-prefixed.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-enabled-prefixed-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
A + LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + LayoutTests/fullscreen/full-screen-iframe-allowed-nested-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-zIndex.html View 1 3 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fullscreen/full-screen-restrictions.html View 1 3 chunks +4 lines, -3 lines 0 comments Download
A + LayoutTests/fullscreen/resources/full-screen-iframe-allowed-nested1.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fullscreen/resources/full-screen-iframe-allowed-nested2.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
D LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
philipj_slow
6 years, 5 months ago (2014-06-30 16:31:02 UTC) #1
falken
lgtm with totally optional nits https://codereview.chromium.org/336313015/diff/1/LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html File LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html (right): https://codereview.chromium.org/336313015/diff/1/LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html#newcode1 LayoutTests/fullscreen/full-screen-iframe-allowed-nested.html:1: <p>Test entering full screen ...
6 years, 5 months ago (2014-07-01 05:03:28 UTC) #2
falken
lgtm with totally optional nits
6 years, 5 months ago (2014-07-01 05:03:29 UTC) #3
philipj_slow
On 2014/07/01 05:03:29, falken wrote: > lgtm with totally optional nits No nit left behind! ...
6 years, 5 months ago (2014-07-01 07:27:29 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-01 07:27:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/336313015/20001
6 years, 5 months ago (2014-07-01 07:28:09 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-01 08:37:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 09:35:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/14795)
6 years, 5 months ago (2014-07-01 09:35:43 UTC) #9
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-01 21:16:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/336313015/40001
6 years, 5 months ago (2014-07-01 21:16:41 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 23:44:08 UTC) #12
Message was sent while issue was closed. 
Change committed as 177332

Powered by Google App Engine
This is Rietveld 408576698