Showing devices transport method in one device

chrome/common/extensions/permissions/chrome_permission_message_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/chrome_permission_message_provider.h"
 
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "extensions/common/extensions_client.h"
 #include "extensions/common/permissions/permission_message.h"
@@ skipping 93 matching lines @@
     Manifest::Type extension_type) const {
   std::vector<base::string16> message_strings;
   PermissionMessages messages =
       GetPermissionMessages(permissions, extension_type);
 
   bool audio_capture = false;
   bool video_capture = false;
   bool media_galleries_read = false;
   bool media_galleries_copy_to = false;
   bool media_galleries_delete = false;
+  int access_to_devices = 0;
+  bool access_to_devices_message_pushed = false;
   for (PermissionMessages::const_iterator i = messages.begin();
        i != messages.end(); ++i) {
     switch (i->id()) {
       case PermissionMessage::kAudioCapture:
         audio_capture = true;
         break;
       case PermissionMessage::kVideoCapture:
         video_capture = true;
         break;
       case PermissionMessage::kMediaGalleriesAllGalleriesRead:
         media_galleries_read = true;
         break;
       case PermissionMessage::kMediaGalleriesAllGalleriesCopyTo:
         media_galleries_copy_to = true;
         break;
       case PermissionMessage::kMediaGalleriesAllGalleriesDelete:
         media_galleries_delete = true;
         break;
+      case PermissionMessage::kBluetoothDevices:
+      case PermissionMessage::kHid:
+      case PermissionMessage::kSerial:
+      case PermissionMessage::kUsbDevice:

[meacer, 2014/06/18 02:25:02]

These should be kUsb and kBluetooth instead, as those are the permissions
allowing device enumeration. As a quick test, you can create a simple manifest
and check the permissions in chrome://extensions page:

{ "name": "Test,"
  "manifest_version": 2,
  "version": "1.0",
  "permissions": ["usb", "bluetooth"]
}

[Ken Rockot(use gerrit already), 2014/06/18 21:06:17]

kUsb and kBluetooth are correct, yes.

The k[Usb,Bluetooth]Device(s) permissions are for listing more specific device
constraints (like VID/PID for a USB device). They're a practical prerequisite
for using the APIs, but they are not interesting permissions in this case, I
think.

[mhm, 2014/06/18 22:16:44]

rockot@ aren't these two only used to list the Bluetooth/USb device and not to
access the devices themselves?

+        access_to_devices += 1;
       default:
         break;
     }
   }
 
   for (PermissionMessages::const_iterator i = messages.begin();
        i != messages.end(); ++i) {
     int id = i->id();
+    if (access_to_devices > 1) {
+      if (!access_to_devices_message_pushed) {
+        message_strings.push_back(
+            l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_DEVICES));
+        access_to_devices_message_pushed = true;
+        continue;
+      }
+      if (id == PermissionMessage::kBluetoothDevices ||
+          id == PermissionMessage::kHid || id == PermissionMessage::kSerial ||
+          id == PermissionMessage::kUsbDevice) {
+        continue;
+      }

[not at google - send to devlin, 2014/06/18 20:53:32]

I think the upgrade path here is a bit weird. What if I install an extensoin and
it says "access to your bluetooth devices" and then it upgrades and says "access
to your hardware".

I'm ok with just grouping these no matter what ("access to hardware"). Perhaps
ideally we'd turn usb + bluetooth into "your usb and bluetooth devices" but that
would require setting up a full ManifestPermission for this:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

+    }
     if (audio_capture && video_capture) {
       if (id == PermissionMessage::kAudioCapture) {
         message_strings.push_back(l10n_util::GetStringUTF16(
             IDS_EXTENSION_PROMPT_WARNING_AUDIO_AND_VIDEO_CAPTURE));
         continue;
       } else if (id == PermissionMessage::kVideoCapture) {
         // The combined message will be pushed above.
         continue;
       }
     }
@@ skipping 217 matching lines @@
   std::set<std::string> old_hosts_set(
       permission_message_util::GetDistinctHosts(old_list, false, false));
   std::set<std::string> new_hosts_only =
       base::STLSetDifference<std::set<std::string> >(new_hosts_set,
                                                      old_hosts_set);
 
   return !new_hosts_only.empty();
 }
 
 }  // namespace extensions