mojo: Don't leak handles when assigning to ScopedHandles.

mojo/public/cpp/system/core.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_SYSTEM_CORE_H_
 #define MOJO_PUBLIC_CPP_SYSTEM_CORE_H_
 
 #include <assert.h>
 #include <stddef.h>
 
@@ skipping 89 matching lines @@
   ~ScopedHandleBase() { CloseIfNecessary(); }
 
   template <class CompatibleHandleType>
   explicit ScopedHandleBase(ScopedHandleBase<CompatibleHandleType> other)
       : handle_(other.release()) {
   }
 
   // Move-only constructor and operator=.
   ScopedHandleBase(RValue other) : handle_(other.object->release()) {}
   ScopedHandleBase& operator=(RValue other) {
+    if (handle_.is_valid() && handle_.value() != other.object->get().value())

[viettrungluu, 2014/06/17 22:58:25]

Since a handle should only be in a single ScopedHandleBase<> at any particular
time, you could simplify this to:

if (other.object != this)
  CloseIfNecessary();

(CloseIfNecessary() checks for validity).

Or maybe better (more self-evidently correct):

if (other.object != this) {
  CloseIfNecessary();
  handle_ = other.object->release();
}
return *this;

You might also add an |assert(handle_.value() != other.object->get().value());|
before the |CloseIfNecessary();| (inside the if block).

[Elliot Glaysher, 2014/06/17 23:08:28]

Switched to if (other.object != this). Didn't add the assert, because wouldn't
that trigger on an assignment of a closed handle to a closed handle?

+      CloseIfNecessary();
     handle_ = other.object->release();
     return *this;
   }
 
   const HandleType& get() const { return handle_; }
 
   template <typename PassedHandleType>
   static ScopedHandleBase<HandleType> From(
       ScopedHandleBase<PassedHandleType> other) {
     MOJO_COMPILE_ASSERT(
@@ skipping 422 matching lines @@
       CreateSharedBuffer(&options, num_bytes, &handle);
   assert(result == MOJO_RESULT_OK);
 }
 
 inline SharedBuffer::~SharedBuffer() {
 }
 
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_SYSTEM_CORE_H_