Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation
Patch Set: Addressed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index 30b47890802068aae42b6a698f0e063a8459f3ca..1593b59fd9f1f6d747cd8591ec254d6d3a1914c0 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -123,19 +123,6 @@ void BrowserPluginEmbedder::OnGuestCallback(
BrowserPluginGuest* guest = guest_web_contents ?
static_cast<WebContentsImpl*>(guest_web_contents)->
GetBrowserPluginGuest() : NULL;
- if (!guest) {
- scoped_ptr<base::DictionaryValue> copy_extra_params(
- extra_params->DeepCopy());
- guest_web_contents = GetBrowserPluginGuestManager()->CreateGuest(
- GetWebContents()->GetSiteInstance(),
- instance_id,
- copy_extra_params.Pass());
- guest = guest_web_contents
- ? static_cast<WebContentsImpl*>(guest_web_contents)
- ->GetBrowserPluginGuest()
- : NULL;
- }
-
if (guest)
guest->Attach(GetWebContents(), params, *extra_params);
}

Powered by Google App Engine
This is Rietveld 408576698