chrome/common/extensions/api/guest_view_internal.json - Issue 336283002: Remove GuestWebContentsCreated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/guest_view_internal.json

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation

Patch Set: Addressed comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/guest_view_internal.json

diff --git a/chrome/common/extensions/api/guest_view_internal.json b/chrome/common/extensions/api/guest_view_internal.json

index d677ae7b0865fba85ba2b0857f3771d11a173fbf..50f9ab74f723d577e85a88338e86b5f3f0563261 100644

--- a/chrome/common/extensions/api/guest_view_internal.json

+++ b/chrome/common/extensions/api/guest_view_internal.json

@@ -11,10 +11,25 @@

"description": "none",

"functions": [

{

- "name": "allocateInstanceId",

+ "name": "createGuest",

"type": "function",

"parameters": [

{

+ "type": "string",

+ "name": "viewType",

+ "nodoc": true

+ },

+ {

+ "type": "object",

+ "name": "createParams",

+ "properties": {

+ "storagePartitionId": {

+ "type": "string",

+ "optional": true

+ }

+ },

+ {

"type": "function",

"name": "callback",

"parameters": [