Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation
Patch Set: Addressed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.h
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h
index 5baa498f3a8d45f572909bd1d49717d6ef77e492..e50bab753a450190a55f784f2eb4e01fa2e4616d 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.h
+++ b/chrome/browser/guest_view/web_view/web_view_guest.h
@@ -44,9 +44,7 @@ class SimpleMenuModel;
class WebViewGuest : public GuestView<WebViewGuest>,
public content::NotificationObserver {
public:
- WebViewGuest(int guest_instance_id,
- content::WebContents* guest_web_contents,
- const std::string& embedder_extension_id);
+ explicit WebViewGuest(int guest_instance_id);
// For WebViewGuest, we create special guest processes, which host the
// tag content separately from the main application that embeds the tag.
@@ -63,12 +61,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,
// Returns guestview::kInstanceIDNone if |contents| does not correspond to a
// WebViewGuest.
static int GetViewInstanceId(content::WebContents* contents);
- // Parses partition related parameters from |extra_params|.
- // |storage_partition_id| is the parsed partition ID and |persist_storage|
- // specifies whether or not the partition is in memory.
- static void ParsePartitionParam(const base::DictionaryValue* extra_params,
- std::string* storage_partition_id,
- bool* persist_storage);
+
static const char Type[];
// Request navigating the guest to the provided |src| URL.
@@ -88,7 +81,13 @@ class WebViewGuest : public GuestView<WebViewGuest>,
void SetZoom(double zoom_factor);
// GuestViewBase implementation.
+ virtual void CreateWebContents(
+ const std::string& embedder_extension_id,
+ int embedder_render_process_id,
+ const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback) OVERRIDE;
virtual void DidAttachToEmbedder() OVERRIDE;
+ virtual void DidInitialize() OVERRIDE;
virtual void DidStopLoading() OVERRIDE;
virtual void EmbedderDestroyed() OVERRIDE;
virtual void GuestDestroyed() OVERRIDE;
@@ -151,6 +150,8 @@ class WebViewGuest : public GuestView<WebViewGuest>,
content::WebContents* new_contents) OVERRIDE;
// BrowserPluginGuestDelegate implementation.
+ virtual content::WebContents* CreateNewGuestWindow(
+ const content::WebContents::CreateParams& create_params) OVERRIDE;
virtual void SizeChanged(const gfx::Size& old_size, const gfx::Size& new_size)
OVERRIDE;
virtual void RequestPointerLockPermission(
@@ -429,7 +430,8 @@ class WebViewGuest : public GuestView<WebViewGuest>,
void OnUpdateFrameName(bool is_top_level, const std::string& name);
// Creates a new guest window owned by this WebViewGuest.
- WebViewGuest* CreateNewGuestWindow(const content::OpenURLParams& params);
+ WebViewGuest* CreateNewGuestWebViewWindow(
+ const content::OpenURLParams& params);
bool HandleKeyboardShortcuts(const content::NativeWebKeyboardEvent& event);

Powered by Google App Engine
This is Rietveld 408576698