Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation
Patch Set: Fix diff Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 7abd7371a259e336dddd08b6927cb6245279cc7b..05a0efb53add4951287daf95e6f554eea3504db6 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -8,6 +8,7 @@
#include "base/callback_forward.h"
#include "base/process/kill.h"
#include "content/common/content_export.h"
+#include "content/public/browser/web_contents.h"
namespace base {
class DictionaryValue;
@@ -19,8 +20,6 @@ class Size;
namespace content {
-class WebContents;
-
// Objects implement this interface to get notified about changes in the guest
// WebContents and to provide necessary functionality.
class CONTENT_EXPORT BrowserPluginGuestDelegate {
@@ -32,9 +31,15 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
virtual void WillAttach(content::WebContents* embedder_web_contents,
const base::DictionaryValue& extra_params) {}
+ virtual WebContents* CreateNewGuestWindow(
+ const WebContents::CreateParams& create_params);
+
// Notification that the embedder has completed attachment.
virtual void DidAttach() {}
+ // Requests the instance ID associated with the delegate.
+ virtual int GetGuestInstanceID() const;
+
// Notifies that the content size of the guest has changed in autosize mode.
virtual void SizeChanged(const gfx::Size& old_size,
const gfx::Size& new_size) {}

Powered by Google App Engine
This is Rietveld 408576698