Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation
Patch Set: Fix diff Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/guest_view_internal.json ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | extensions/browser/extension_function_histogram_value.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 376f850b193512ad814acd34d6df4213a31d02c7..e2d8783a486a803820d0d0d7c6488c9430b522ba 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -749,9 +749,16 @@ WebViewInternal.prototype.hasGuestInstanceID = function() {
};
WebViewInternal.prototype.allocateInstanceId = function() {
- // Parse .src and .partition.
+ var storagePartitionId =
+ this.webviewNode.getAttribute(WEB_VIEW_ATTRIBUTE_PARTITION) ||
+ this.webviewNode[WEB_VIEW_ATTRIBUTE_PARTITION];
+ var params = {
+ 'storagePartitionId': storagePartitionId,
+ };
var self = this;
- GuestViewInternal.allocateInstanceId(
+ GuestViewInternal.createGuest(
+ 'webview',
+ params,
function(instanceId) {
self.instanceId = instanceId;
// TODO(lazyboy): Make sure this.autoNavigate_ stuff correctly updated
« no previous file with comments | « chrome/common/extensions/api/guest_view_internal.json ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | extensions/browser/extension_function_histogram_value.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698