QUIC - cleanup changes to keep in sync with internal source tree.

QUIC - cleanup changes to keep in sync with internal source tree.

This CL fixes the comments in Patch Set 4 of CL: 331143006 which were
made in the internal source tree first.

  https://codereview.chromium.org/331143006/#ps80001

+ Don't use static_cast<uint32>.
+ Comment fixes
+ Added  COMPILE_ASSERT(sizeof(QuicTag) ==  == sizeof(uint32)
+ Use uint32 instead of QuicTag.

Merge internal change: 69652987

R=rch@chromium.org, wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278942

[wtc, 2014-06-20 23:21:02]

Patch set 1 LGTM.

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/crypto_serve...
File net/quic/crypto/crypto_server_test.cc (right):

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/crypto_serve...
net/quic/crypto/crypto_server_test.cc:273: const uint32* reject_reasons;

We should also COMPILE_ASSERT sizeof(QuicTag) == sizeof(uint32) here.

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/quic_crypto_...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_client_config.cc:590: const uint32* reject_reasons;

We should also COMPILE_ASSERT sizeof(QuicTag) == sizeof(uint32) here.

[ramant (doing other things), 2014-06-20 23:33:25]

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/crypto_serve...
File net/quic/crypto/crypto_server_test.cc (right):

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/crypto_serve...
net/quic/crypto/crypto_server_test.cc:273: const uint32* reject_reasons;
On 2014/06/20 23:21:01, wtc wrote:
> 
> We should also COMPILE_ASSERT sizeof(QuicTag) == sizeof(uint32) here.

Done.

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/quic_crypto_...
File net/quic/crypto/quic_crypto_client_config.cc (right):

https://codereview.chromium.org/336273006/diff/1/net/quic/crypto/quic_crypto_...
net/quic/crypto/quic_crypto_client_config.cc:590: const uint32* reject_reasons;
On 2014/06/20 23:21:01, wtc wrote:
> 
> We should also COMPILE_ASSERT sizeof(QuicTag) == sizeof(uint32) here.

Done.

[wtc, 2014-06-20 23:44:45]

Patch set 2 LGTM.

[ramant (doing other things), 2014-06-20 23:48:26]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-06-20 23:49:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/336273006/20001

[commit-bot: I haz the power, 2014-06-21 06:02:24]

Change committed as 278942