Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chrome/browser/ssl/ssl_error_classification.cc

Issue 336273002: Suggest upgrading to SP3 or later for invalid certificate errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_error_classification.cc
diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc
index ae9283c190f73594e2622102a2336d99b318f4c2..c81c88794f06e42f1a8adbbf0451a57a347dd0f5 100644
--- a/chrome/browser/ssl/ssl_error_classification.cc
+++ b/chrome/browser/ssl/ssl_error_classification.cc
@@ -16,6 +16,10 @@ using base::Time;
using base::TimeTicks;
using base::TimeDelta;
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
namespace {
// Events for UMA. Do not reorder or change!
@@ -116,6 +120,16 @@ bool SSLErrorClassification::IsUserClockInTheFuture(base::Time time_now) {
return false;
}
+bool SSLErrorClassification::IsWindowsVersionSP3OrLower() {
+#if defined(OS_WIN)
+ const base::win::OSInfo* os_info = base::win::OSInfo::GetInstance();
+ base::win::OSInfo::ServicePack service_pack = os_info->service_pack();
+ if (os_info->version() < base::win::VERSION_VISTA && service_pack.major < 3)
+ return true;
+#endif
+ return false;
+}
+
void SSLErrorClassification::RecordUMAStatistics(bool overridable) {
if (IsUserClockInThePast(base::Time::NowFromSystemTime()))
RecordSSLInterstitialCause(overridable, CLOCK_PAST);
« chrome/app/google_chrome_strings.grd ('K') | « chrome/browser/ssl/ssl_error_classification.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698