Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: chrome/browser/ssl/ssl_error_classification_unittest.cc

Issue 336273002: Suggest upgrading to SP3 or later for invalid certificate errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed complilation errors Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_error_classification_unittest.cc
diff --git a/chrome/browser/ssl/ssl_error_classification_unittest.cc b/chrome/browser/ssl/ssl_error_classification_unittest.cc
index fc4e23fc615da4cdc43ef2f237f4c90126c9d22e..fac33d41994babc521fd602f07841543ec2004b1 100644
--- a/chrome/browser/ssl/ssl_error_classification_unittest.cc
+++ b/chrome/browser/ssl/ssl_error_classification_unittest.cc
@@ -12,6 +12,10 @@
#include "net/test/test_certificate_data.h"
#include "testing/gtest/include/gtest/gtest.h"
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
using base::Time;
TEST(SSLErrorClassification, TestDateInvalidScore) {
@@ -39,3 +43,19 @@ TEST(SSLErrorClassification, TestDateInvalidScore) {
}
}
+
+TEST(SSLErrorClassification, SSLBlockingPageWindowsVersionTest) {
+ bool os_version_win = false;
+#if defined(OS_WIN)
+ os_version_win = true;
+ OSVERSIONINFOEX version_info = { sizeof version_info };
+ GetVersionEx(reinterpret_cast<OSVERSIONINFO*>(&version_info));
+ if ((version_info.dwMajorVersion == 5) && (version_info.dwMinorVersion == 1)
+ && (version_info.wServicePackMajor < 3))
+ EXPECT_TRUE(SSLErrorClassification::IsWindowsVersionSP3OrLower());
+ else
+ EXPECT_FALSE(SSLErrorClassification::IsWindowsVersionSP3OrLower());
+#endif
+ if (!os_version_win)
+ EXPECT_FALSE(SSLErrorClassification::IsWindowsVersionSP3OrLower());
+}
« chrome/app/generated_resources.grd ('K') | « chrome/browser/ssl/ssl_error_classification.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698