Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/ssl/ssl_error_classification.h

Issue 336273002: Suggest upgrading to SP3 or later for invalid certificate errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed complilation errors Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_error_classification.h
diff --git a/chrome/browser/ssl/ssl_error_classification.h b/chrome/browser/ssl/ssl_error_classification.h
index c37ce2e007b820ec55483a50b8fd7de5bda821ad..4318ca3567ad20dfb83b34e7c361bca0a949c9ce 100644
--- a/chrome/browser/ssl/ssl_error_classification.h
+++ b/chrome/browser/ssl/ssl_error_classification.h
@@ -23,6 +23,8 @@ class SSLErrorClassification {
// the user is using a version of Chrome which is more than 1 year old.
static bool IsUserClockInTheFuture(base::Time time_now);
+ static bool IsWindowsVersionSP3OrLower();
+
// A method which calculates the severity score when the ssl error is
// CERT_DATE_INVALID.
float InvalidDateSeverityScore() const;
@@ -32,6 +34,7 @@ class SSLErrorClassification {
private:
FRIEND_TEST_ALL_PREFIXES(SSLErrorClassification, TestDateInvalidScore);
+ FRIEND_TEST_ALL_PREFIXES(SSLErrorClassification, TestWindowsVersion);
float CalculateScoreTimePassedSinceExpiry() const;

Powered by Google App Engine
This is Rietveld 408576698