chrome/browser/resources/ssl/interstitial_v2.js - Issue 336273002: Suggest upgrading to SP3 or later for invalid certificate errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ssl/interstitial_v2.js

Issue 336273002: Suggest upgrading to SP3 or later for invalid certificate errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/ssl/interstitial_v2.js

diff --git a/chrome/browser/resources/ssl/interstitial_v2.js b/chrome/browser/resources/ssl/interstitial_v2.js

index 005114366a1f9ef4247d6d4d2de3ca9da17dcaf7..f05771c1410ac469c2cbacbeedf2932392780f82 100644

--- a/chrome/browser/resources/ssl/interstitial_v2.js

+++ b/chrome/browser/resources/ssl/interstitial_v2.js

@@ -38,7 +38,7 @@ function setupEvents() {

if (ssl && overridable) {

$('proceed-link').classList.add('small-link');

- } else {

+ } else if ($('help-link')) {

palmer 2014/07/07 18:10:03 This looks like a fix for an unrelated bug?

radhikabhar 2014/07/07 22:42:44 Yes. I have just committed it and once I do a reba

// Overridable SSL page doesn't have this link.

$('help-link').addEventListener('click', function(event) {

if (ssl)

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/ssl_blocking_page.h » ('j') | chrome/browser/ssl/ssl_blocking_page.h » ('J')