components/components_tests.gyp - Issue 336263003: Bring up of the metadata accessors for enhanced bookmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/components_tests.gyp

Issue 336263003: Bring up of the metadata accessors for enhanced bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removing use of 'auto'. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/components_tests.gyp

diff --git a/components/components_tests.gyp b/components/components_tests.gyp

index 1ec98df6aaffd49ca8723cb1aef6aa31d90a2f83..4254b96f82dee866635580a4ca37096c02310ad6 100644

--- a/components/components_tests.gyp

+++ b/components/components_tests.gyp

@@ -100,6 +100,7 @@

'domain_reliability/test_util.h',

'domain_reliability/uploader_unittest.cc',

'domain_reliability/util_unittest.cc',

+ 'enhanced_bookmarks/metadata_accessor_unittest.cc',

Kibeom Kim (inactive) 2014/06/18 17:44:57 below image_store_unittest.cc?

noyau (Ping after 24h) 2014/06/19 09:07:00 Ha, I renamed the class and forgot to reorder ever

'enhanced_bookmarks/image_store_unittest.cc',

'feedback/feedback_common_unittest.cc',

'feedback/feedback_data_unittest.cc',

@@ -260,6 +261,7 @@

'components.gyp:domain_reliability',

# Dependencies of enhanced_bookmarks

+ 'components.gyp:enhanced_bookmarks_proto',

Kibeom Kim (inactive) 2014/06/18 17:44:57 isn't this already included as 'components.gyp:enh

noyau (Ping after 24h) 2014/06/19 09:07:00 Done.

'components.gyp:enhanced_bookmarks',

'components.gyp:enhanced_bookmarks_test_support',

@@ -402,6 +404,7 @@

['include', '^bookmarks/'],

['include', '^data_reduction_proxy/'],

['include', '^dom_distiller/'],

+ ['include', '^enhanced_bookmarks/metadata_accessor_unittest\\.cc'],

['include', '^gcm_driver/'],

['include', '^history/'],

['include', '^invalidation/'],

« no previous file with comments | « no previous file | components/enhanced_bookmarks.gypi » ('j') | components/enhanced_bookmarks.gypi » ('J')