Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336263002: Adds an item for loaded app. (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Adds an item for loaded app. A big todo is to load the icon correctly. extension_icon_image is still under chrome/browser for multiple reasons. BUG=380421 R=jamescook@chromium.org, oshima@chromium.org TBR=miket@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277668

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : polish #

Total comments: 2

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -12 lines) Patch
M apps/shell/browser/shell_extension_system.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M athena/athena.gyp View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/content/content_app_model_builder.cc View 1 2 3 4 chunks +52 lines, -5 lines 0 comments Download
M athena/main/athena_main.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-16 20:34:08 UTC) #1
James Cook
lgtm https://codereview.chromium.org/336263002/diff/40001/athena/content/content_app_model_builder.cc File athena/content/content_app_model_builder.cc (right): https://codereview.chromium.org/336263002/diff/40001/athena/content/content_app_model_builder.cc#newcode29 athena/content/content_app_model_builder.cc:29: SkBitmap bitmap; 2 space indent
6 years, 6 months ago (2014-06-16 21:07:02 UTC) #2
Jun Mukai
https://codereview.chromium.org/336263002/diff/40001/athena/content/content_app_model_builder.cc File athena/content/content_app_model_builder.cc (right): https://codereview.chromium.org/336263002/diff/40001/athena/content/content_app_model_builder.cc#newcode29 athena/content/content_app_model_builder.cc:29: SkBitmap bitmap; On 2014/06/16 21:07:02, James Cook wrote: > ...
6 years, 6 months ago (2014-06-16 21:38:36 UTC) #3
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-16 21:38:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/336263002/60001
6 years, 6 months ago (2014-06-16 21:41:56 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 03:46:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74116)
6 years, 6 months ago (2014-06-17 03:46:26 UTC) #7
Jun Mukai
On 2014/06/17 03:46:26, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-17 05:03:50 UTC) #8
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-17 05:03:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/336263002/60001
6 years, 6 months ago (2014-06-17 05:06:04 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 08:22:51 UTC) #11
Message was sent while issue was closed. 
Change committed as 277668

Powered by Google App Engine
This is Rietveld 408576698