Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 336253003: Flip to use chromevox from uncompiled sources. (Closed)

Created:
6 years, 6 months ago by Peter Lundblad
Modified:
6 years, 5 months ago
Reviewers:
David Tseng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Flip to use chromevox from uncompiled sources. The only difference is that ChromeVox is flattened and compressed from the individual source files instead of taken froma closure compiled version from upstream. Deleting the precompiled js binaries and removing support for using that version will be done in a follow-up cl when this has been used on canary/dev for a while. BUG=371692 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Lundblad
6 years, 6 months ago (2014-06-24 20:45:43 UTC) #1
David Tseng
lgtm Still a (little) worried about perf; let's test aggressively.
6 years, 6 months ago (2014-06-25 23:27:46 UTC) #2
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 5 months ago (2014-06-26 15:39:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/336253003/1
6 years, 5 months ago (2014-06-26 15:40:13 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-26 18:00:59 UTC) #5
Message was sent while issue was closed.
Change committed as 280048

Powered by Google App Engine
This is Rietveld 408576698