Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/hydrogen-gvn.cc

Issue 336223002: Revert "GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's repr… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 #include "src/hydrogen-gvn.h" 6 #include "src/hydrogen-gvn.h"
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 global_vars_[num_global_vars_++] = cell; 459 global_vars_[num_global_vars_++] = cell;
460 return true; 460 return true;
461 } 461 }
462 return false; 462 return false;
463 } 463 }
464 464
465 465
466 bool SideEffectsTracker::ComputeInobjectField(HObjectAccess access, 466 bool SideEffectsTracker::ComputeInobjectField(HObjectAccess access,
467 int* index) { 467 int* index) {
468 for (int i = 0; i < num_inobject_fields_; ++i) { 468 for (int i = 0; i < num_inobject_fields_; ++i) {
469 if (access.SameField(inobject_fields_[i])) { 469 if (access.Equals(inobject_fields_[i])) {
470 *index = i; 470 *index = i;
471 return true; 471 return true;
472 } 472 }
473 } 473 }
474 if (num_inobject_fields_ < kNumberOfInobjectFields) { 474 if (num_inobject_fields_ < kNumberOfInobjectFields) {
475 if (FLAG_trace_gvn) { 475 if (FLAG_trace_gvn) {
476 HeapStringAllocator allocator; 476 HeapStringAllocator allocator;
477 StringStream stream(&allocator); 477 StringStream stream(&allocator);
478 stream.Add("Tracking inobject field access "); 478 stream.Add("Tracking inobject field access ");
479 access.PrintTo(&stream); 479 access.PrintTo(&stream);
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 dominated); 904 dominated);
905 successor_map->Kill(side_effects_on_all_paths); 905 successor_map->Kill(side_effects_on_all_paths);
906 successor_dominators->Kill(side_effects_on_all_paths); 906 successor_dominators->Kill(side_effects_on_all_paths);
907 } 907 }
908 } 908 }
909 current = next; 909 current = next;
910 } 910 }
911 } 911 }
912 912
913 } } // namespace v8::internal 913 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698