Issue 336223002: Revert "GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's repr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336223002: Revert "GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's repr… (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer

Modified:
6 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representation is not the same." This reverts commit r21830 for tanking performance on Deltablue. TBR=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21857

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -36 lines)			Patch
M	src/hydrogen-gvn.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
D	test/mjsunit/regress/regress-gvn-ftt.js	View	1 chunk	+0 lines, -27 lines	0 comments	Download

Total messages: 1 (0 generated)

Benedikt Meurer

6 years, 6 months ago (2014-06-16 13:04:12 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r21857 (tree was closed).