Issue 336213002: Types for m_maximumAge and m_timeout in PositionOptions class should be changed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336213002: Types for m_maximumAge and m_timeout in PositionOptions class should be changed (Closed)

Created:
6 years, 6 months ago by kihong

Modified:
6 years, 6 months ago

Reviewers:
haraken, Michael van Ouwerkerk

CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Types for m_maximumAge and m_timeout in PositionOptions class should be changed Types of m_maximumAge and m_imeout are "unsigned long" but they are "int". Therefore their types should change to "unsigned" for align with others. BUG=368184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176266

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/modules/geolocation/PositionOptions.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/336213002/1

6 years, 6 months ago (2014-06-17 00:28:14 UTC) #5

Message was sent while issue was closed.

Change committed as 176266

Expand Messages | Collapse Messages