Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336193003: Make FileSystemURL::ToGURL consistent with DOMFileSystemBase. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
ericu, fukino, tzik
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

Make FileSystemURL::ToGURL consistent with DOMFileSystemBase. Encoding scheme for the path component of the file system URL differs between these classes, that is causing mismatch in some cases. BUG=384222 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277695

Patch Set 1 #

Patch Set 2 : Fix win test failure (hopefully) #

Total comments: 2

Patch Set 3 : KURL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/browser/fileapi/file_system_url_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_url.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kinaba
@fukino, does this patch fixes the issue?
6 years, 6 months ago (2014-06-16 10:00:46 UTC) #1
kinaba
PTAL
6 years, 6 months ago (2014-06-16 10:03:38 UTC) #2
fukino
On 2014/06/16 10:00:46, kinaba wrote: > @fukino, does this patch fixes the issue? lgtm. This ...
6 years, 6 months ago (2014-06-16 10:56:35 UTC) #3
kinaba
Oops the tests on win bots are really failing. I'll take a look tomorrow.
6 years, 6 months ago (2014-06-16 14:37:57 UTC) #4
kinaba
+ericu from content/browser/fileapi/OWNERS On 2014/06/16 14:37:57, kinaba wrote: > Oops the tests on win bots ...
6 years, 6 months ago (2014-06-16 23:52:25 UTC) #5
ericu
lgtm
6 years, 6 months ago (2014-06-17 01:17:40 UTC) #6
tzik
lgtm https://codereview.chromium.org/336193003/diff/20001/webkit/browser/fileapi/file_system_url.cc File webkit/browser/fileapi/file_system_url.cc (right): https://codereview.chromium.org/336193003/diff/20001/webkit/browser/fileapi/file_system_url.cc#newcode91 webkit/browser/fileapi/file_system_url.cc:91: // behavior. There the path is escaped by ...
6 years, 6 months ago (2014-06-17 02:19:27 UTC) #7
kinaba
https://codereview.chromium.org/336193003/diff/20001/webkit/browser/fileapi/file_system_url.cc File webkit/browser/fileapi/file_system_url.cc (right): https://codereview.chromium.org/336193003/diff/20001/webkit/browser/fileapi/file_system_url.cc#newcode91 webkit/browser/fileapi/file_system_url.cc:91: // behavior. There the path is escaped by KRUL::encodeWithURLEscapeSequences, ...
6 years, 6 months ago (2014-06-17 02:26:10 UTC) #8
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-17 02:26:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/336193003/40001
6 years, 6 months ago (2014-06-17 02:30:05 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 09:59:44 UTC) #11
Message was sent while issue was closed. 
Change committed as 277695

Powered by Google App Engine
This is Rietveld 408576698