Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 336183005: Remove title() from TimelineModel.Record (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineView.js
diff --git a/Source/devtools/front_end/timeline/TimelineView.js b/Source/devtools/front_end/timeline/TimelineView.js
index e5b0a00a99ec3631b72f154ba6786c5d5ce31923..2072f44a126a1d35933244728255697860db47c3 100644
--- a/Source/devtools/front_end/timeline/TimelineView.js
+++ b/Source/devtools/front_end/timeline/TimelineView.js
@@ -40,11 +40,11 @@
WebInspector.TimelineView = function(delegate, model, uiUtils)
{
WebInspector.HBox.call(this);
- this._uiUtils = uiUtils;
this.element.classList.add("timeline-view");
this._delegate = delegate;
this._model = model;
+ this._uiUtils = uiUtils;
this._presentationModel = new WebInspector.TimelinePresentationModel(model, uiUtils);
this._calculator = new WebInspector.TimelineCalculator(model);
this._linkifier = new WebInspector.Linkifier();
@@ -135,7 +135,8 @@ WebInspector.TimelineView.prototype = {
var dividerPosition = Math.round(position);
if (dividerPosition < 0 || dividerPosition >= clientWidth || dividers[dividerPosition])
continue;
- var divider = this._uiUtils.createEventDivider(record.type(), record.title());
+ var title = this._uiUtils.titleForRecord(record);
+ var divider = this._uiUtils.createEventDivider(record.type(), title);
divider.style.left = dividerPosition + "px";
dividers[dividerPosition] = divider;
}
@@ -1065,7 +1066,7 @@ WebInspector.TimelineRecordListRow.prototype = {
if (record.thread())
this.element.classList.add("background");
- this._typeElement.textContent = record.title();
+ this._typeElement.textContent = uiUtils.titleForRecord(record);
if (this._dataElement.firstChild)
this._dataElement.removeChildren();
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698