Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 336183005: Remove title() from TimelineModel.Record (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 6fa2a41ec833030b5eef670b34d2d614ac1c3db1..934e679d410ebcaf61f67edd08c15022b7065703 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -85,6 +85,14 @@ WebInspector.TimelineUIUtils.prototype = {
},
/**
* @param {!WebInspector.TimelineModel.Record} record
+ * @return {string}
+ */
+ titleForRecord: function(record)
+ {
+ throw new Error("Not implemented.");
+ },
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
* @param {!WebInspector.Linkifier} linkifier
* @param {boolean} loadedFromFile
* @return {?Node}
@@ -112,6 +120,15 @@ WebInspector.TimelineUIUtils.prototype = {
createEventDivider: function(recordType, title)
{
throw new Error("Not implemented.");
+ },
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @param {!RegExp} regExp
+ * @return {boolean}
+ */
+ testContentMatching: function(record, regExp)
+ {
+ throw new Error("Not implemented.");
}
}
@@ -243,25 +260,6 @@ WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent = function(model,
}
/**
- * @param {!WebInspector.TimelineModel.Record} record
- * @param {!WebInspector.TimelineModel} model
- * @return {string}
- */
-WebInspector.TimelineUIUtils.recordTitle = function(record, model)
-{
- var recordData = record.data();
- if (record.type() === WebInspector.TimelineModel.RecordType.TimeStamp)
- return recordData["message"];
- if (record.type() === WebInspector.TimelineModel.RecordType.JSFrame)
- return recordData["functionName"];
- if (WebInspector.TimelineUIUtilsImpl.isEventDivider(record)) {
- var startTime = Number.millisToString(record.startTime() - model.minimumRecordTime());
- return WebInspector.UIString("%s at %s", WebInspector.TimelineUIUtils.recordStyle(record).title, startTime, true);
- }
- return WebInspector.TimelineUIUtils.recordStyle(record).title;
-}
-
-/**
* @param {!Object} total
* @param {!Object} addend
*/
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698