Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 336183005: Remove title() from TimelineModel.Record (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 * @return {?string} 83 * @return {?string}
84 */ 84 */
85 entryTitle: function(entryIndex) 85 entryTitle: function(entryIndex)
86 { 86 {
87 var record = this._records[entryIndex]; 87 var record = this._records[entryIndex];
88 if (record === this._cpuThreadRecord) 88 if (record === this._cpuThreadRecord)
89 return WebInspector.UIString("CPU"); 89 return WebInspector.UIString("CPU");
90 else if (record === this._gpuThreadRecord) 90 else if (record === this._gpuThreadRecord)
91 return WebInspector.UIString("GPU"); 91 return WebInspector.UIString("GPU");
92 var details = WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, this._linkifier, this._model.loadedFromFile()); 92 var details = WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, this._linkifier, this._model.loadedFromFile());
93 return details ? WebInspector.UIString("%s (%s)", record.title(), detail s.textContent) : record.title(); 93 var title = WebInspector.TimelineUIUtilsImpl.recordTitle(record);
94 return details ? WebInspector.UIString("%s (%s)", title, details.textCon tent) : title;
94 }, 95 },
95 96
96 /** 97 /**
97 * @param {number} startTime 98 * @param {number} startTime
98 * @param {number} endTime 99 * @param {number} endTime
99 * @return {?Array.<number>} 100 * @return {?Array.<number>}
100 */ 101 */
101 dividerOffsets: function(startTime, endTime) 102 dividerOffsets: function(startTime, endTime)
102 { 103 {
103 // While we have tracing and timeline flame chart on screen at a time, 104 // While we have tracing and timeline flame chart on screen at a time,
(...skipping 866 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 * @param {number} entryIndex 971 * @param {number} entryIndex
971 * @return {?WebInspector.TimelineSelection} 972 * @return {?WebInspector.TimelineSelection}
972 */ 973 */
973 createSelection: function(entryIndex) { }, 974 createSelection: function(entryIndex) { },
974 /** 975 /**
975 * @param {?WebInspector.TimelineSelection} selection 976 * @param {?WebInspector.TimelineSelection} selection
976 * @return {number} 977 * @return {number}
977 */ 978 */
978 entryIndexForSelection: function(selection) { } 979 entryIndexForSelection: function(selection) { }
979 } 980 }
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698