Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 336183005: Remove title() from TimelineModel.Record (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove title() from TimelineModel.Record title is a presentation entity and shouldn't be exposed on model record. TimelineUIUtils should be used to retrieve it. BUG=361045 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -84 lines) Patch
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 2 chunks +1 line, -12 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 2 chunks +1 line, -21 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 5 chunks +8 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 3 chunks +17 lines, -19 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 3 chunks +41 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
6 years, 6 months ago (2014-06-19 11:34:53 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-19 11:41:35 UTC) #2
yurys
6 years, 6 months ago (2014-06-19 11:57:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r176503 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698