Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 336163003: Remove excessive include of ActiveAnimations.h (Closed)

Created:
6 years, 6 months ago by davve
Modified:
6 years, 6 months ago
Reviewers:
rune
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove excessive include of ActiveAnimations.h CSSAnimations.h, having being changed 23 times in the last 90 days, had prior to this patch roughly 507 targets depending on it. After this patch, the number has shrunk to 17. This patch removes unnecessary ActiveAnimation.h includes, from which CSSAnimations.h is included. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176748

Patch Set 1 #

Patch Set 2 : Correct include paths #

Patch Set 3 : One more use of RuntimeEnabledFeatures detected by the bots; add it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/LayoutRepainter.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderInline.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerBlendInfo.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
davve
PTAL
6 years, 6 months ago (2014-06-19 15:08:45 UTC) #1
rune
lgtm
6 years, 6 months ago (2014-06-19 21:00:51 UTC) #2
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-06-19 21:08:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/336163003/20001
6 years, 6 months ago (2014-06-19 21:09:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-19 21:51:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 22:32:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19227)
6 years, 6 months ago (2014-06-19 22:32:18 UTC) #7
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-06-23 08:19:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/336163003/20001
6 years, 6 months ago (2014-06-23 08:19:42 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-23 10:12:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 10:54:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19227)
6 years, 6 months ago (2014-06-23 10:54:22 UTC) #12
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-06-23 11:58:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/336163003/40001
6 years, 6 months ago (2014-06-23 11:59:18 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 13:00:47 UTC) #15
Message was sent while issue was closed.
Change committed as 176748

Powered by Google App Engine
This is Rietveld 408576698