Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 336153003: Keep track of paths for fallback fonts in sandbox_ipc_linux (Closed)

Created:
6 years, 6 months ago by Dominik Röttsches
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Keep track of paths for fallback fonts in sandbox_ipc_linux Similar to HandleFontMatchRequest we need to keep track of the path of a font that was found when searching for a character fallback. Otherwise the renderer cannot instantiate them later through Skia's SkFontConfigInterface. Depends on Blink side change that extends WebFallbackFont by fontconfigInterfaceId (r176494). BUG=285303 R=piman,eae Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279018

Patch Set 1 #

Patch Set 2 : Rebased on fciId->fontconfigInterfaceId rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dominik Röttsches
Depends on blink side change in https://codereview.chromium.org/340073002/
6 years, 6 months ago (2014-06-18 13:26:42 UTC) #1
piman
lgtm
6 years, 6 months ago (2014-06-18 21:40:19 UTC) #2
Dominik Röttsches
On 2014/06/18 21:40:19, piman wrote: > lgtm thx!
6 years, 6 months ago (2014-06-18 21:42:20 UTC) #3
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-19 11:16:12 UTC) #4
Dominik Röttsches
The CQ bit was unchecked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-19 11:16:20 UTC) #5
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-22 16:16:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/336153003/20001
6 years, 6 months ago (2014-06-22 16:17:00 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-22 20:17:53 UTC) #8
Message was sent while issue was closed.
Change committed as 279018

Powered by Google App Engine
This is Rietveld 408576698