Issue 336153002: Revert of Properly route screen orientation IPC messages.

Issue 336153002: Revert of Properly route screen orientation IPC messages. (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
jam, dcheng, mlamouri (slow - plz ping)

CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@screen_lock_view

Visibility:
Public.

Revert of Properly route screen orientation IPC messages. (https://codereview.chromium.org/327573002/) Reason for revert: Broke screen_orientation/lockOrientation-sandboxed-iframe.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=screen_orientation/lockOrientation-sandboxed-iframe.html Original issue's description: > Properly route screen orientation IPC messages. > > The messages will now go trough RF/RFH. > This is in order to make screen orientation lock Frame specific > instead of global to Chromium. The next step is to change the provider > accordingly. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277321 TBR=dcheng@chromium.org,jam@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277346

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -90 lines)			Patch
M	content/browser/android/content_view_core_impl.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.h	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	6 chunks	+11 lines, -0 lines	0 comments	Download
M	content/browser/screen_orientation/screen_orientation_dispatcher_host.h	View	1 chunk	+13 lines, -15 lines	0 comments	Download
M	content/browser/screen_orientation/screen_orientation_dispatcher_host.cc	View	3 chunks	+10 lines, -20 lines	0 comments	Download
M	content/browser/screen_orientation/screen_orientation_dispatcher_host_unittest.cc	View	7 chunks	+13 lines, -20 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/common/screen_orientation_messages.h	View	2 chunks	+11 lines, -12 lines	0 comments	Download
M	content/renderer/screen_orientation/screen_orientation_dispatcher.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc	View	6 chunks	+2 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

tkent

Created Revert of Properly route screen orientation IPC messages.

6 years, 6 months ago (2014-06-16 01:30:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/336153002/1

6 years, 6 months ago (2014-06-16 01:30:54 UTC) #2

Message was sent while issue was closed.

Change committed as 277346