Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 336143002: Revert of Textarea resize-able only to larger; min-height and min-width properly set (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Textarea resize-able only to larger; min-height and min-width properly set (https://codereview.chromium.org/239983004/) Reason for revert: Regression for RTL textareas. Original issue's description: > Textarea resize-able only to larger; min-height and min-width properly set > > Textarea does not respect the min-height and min-width property when they are > set by user. When textarea min-height and min-width is set by the user and > if we resize textarea it will only resize to value larger than the width and > heght of textarea and not with value smaller than it's width and height. It > assumes width and height as min-width and min height and does not take into > account the actual min-width and min-height set by user. This patch removes > this bug by initializing the setMinimumSizeForResizing value with min-width > and min-height. > > BUG=94583 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173269 BUG=94583, 371743 TBR=harpreet.sk@samsung.com, chaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176170

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -314 lines) Patch
D LayoutTests/fast/forms/text-area-resize-orthogonal-containingBlock.html View 1 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/fast/forms/text-area-resize-orthogonal-containingBlock-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/forms/textarea-resize-above-min-size-set-and-below-initial-size.html View 1 1 chunk +0 lines, -66 lines 0 comments Download
D LayoutTests/fast/forms/textarea-resize-above-min-size-set-and-below-initial-size-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/forms/textarea-resize-below-min-intrinsic-size.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/forms/textarea-resize-below-min-intrinsic-size-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/forms/textarea-resize-below-min-size-set.html View 1 1 chunk +0 lines, -78 lines 0 comments Download
D LayoutTests/fast/forms/textarea-resize-below-min-size-set-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M Source/core/dom/ElementRareData.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 4 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
Created Revert of Textarea resize-able only to larger; min-height and min-width properly set
6 years, 6 months ago (2014-06-15 23:37:46 UTC) #1
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-15 23:40:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/336143002/1
6 years, 6 months ago (2014-06-15 23:41:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 00:28:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16999)
6 years, 6 months ago (2014-06-16 00:28:53 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-16 01:10:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/336143002/150001
6 years, 6 months ago (2014-06-16 01:11:46 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 03:27:59 UTC) #8
Message was sent while issue was closed.
Change committed as 176170

Powered by Google App Engine
This is Rietveld 408576698