Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: remoting/client/plugin/pepper_network_manager.cc

Issue 336113002: Avoid error messages from UDP sockets in Chromoting client. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/client/plugin/pepper_packet_socket_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/pepper_network_manager.cc
diff --git a/remoting/client/plugin/pepper_network_manager.cc b/remoting/client/plugin/pepper_network_manager.cc
index b4787ca7c836e61ef84ccefc9ea65fb7b0b10ccc..a60d3304b80b741a2fca0ed1eaf29232ebd609e0 100644
--- a/remoting/client/plugin/pepper_network_manager.cc
+++ b/remoting/client/plugin/pepper_network_manager.cc
@@ -76,6 +76,14 @@ void PepperNetworkManager::OnNetworkList(int32_t result,
for (size_t i = 0; i < addresses.size(); ++i) {
talk_base::SocketAddress address;
PpNetAddressToSocketAddress(addresses[i], &address);
+
+ if (address.family() == AF_INET6 && IPIsSiteLocal(address.ipaddr())) {
+ // Link-local IPv6 addresses can't be bound via the current PPAPI
+ // Bind() interface as designed (see crbug.com/384854); trying to do so
+ // would fail.
+ continue;
+ }
+
talk_base::Network* network = new talk_base::Network(
list.GetName(i), list.GetDisplayName(i), address.ipaddr(), 0);
network->AddIP(address.ipaddr());
« no previous file with comments | « no previous file | remoting/client/plugin/pepper_packet_socket_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698