Cleanup some garden-o-matic cruft and dead code.

Tools/GardeningServer/scripts/ui/notifications.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 
 var kMaxTestsPerGroup = 3;
 
 ui.notifications.Stream = base.extends('ol', {
     init: function()
     {
         this.className = 'notifications';
     },
     add: function(notification)
     {
-        var insertBefore = null;
-        Array.prototype.some.call(this.children, function(existingNotification) {
-            if (existingNotification.index() < notification.index()) {
-                insertBefore = existingNotification;
-                return true;
-            }
-        });
-        this.insertBefore(notification, insertBefore);
+        this.appendChild(notification);

[ojan, 2014/06/14 18:42:11]

Now that Notification doesn't have index, we would never set insertBefore here.

         return notification;
     }
 });
 
 ui.notifications.Notification = base.extends('li', {
     init: function()
     {
         this._how = this.appendChild(document.createElement('div'));
         this._how.className = 'how';
         this._what = this.appendChild(document.createElement('div'));
         this._what.className = 'what';
         this._index = 0;
         $(this).hide().fadeIn('fast');
     },
-    index: function()
-    {
-        return this._index;
-    },
-    setIndex: function(index)
-    {
-        this._index = index;
-    },
     dismiss: function()
     {
         // FIXME: These fade in/out effects are lame.
         $(this).fadeOut(function()
         {
             this.parentNode && this.parentNode.removeChild(this);
         });
     },
 });
 
@@ skipping 49 matching lines @@
         return this._revision == revision;
     },
     _addDetail: function(part, commitData, linkFunction)
     {
         var content = commitData[part];
         if (!content)
             return;
 
         var span = this._details.appendChild(document.createElement('span'));
         span.className = part;
-        
+
         if (linkFunction) {
             var parts = $.isArray(content) ? content : [content];
             parts.forEach(function(item, index) {
                 if (index > 0)
                     span.appendChild(document.createTextNode(', '));
                 var link = ui.createLinkNode(linkFunction(item), item);
                 link.className = part + '-item';
                 span.appendChild(link);
             });
         } else {
             span.textContent = content;
         }
     }
 });
 
 ui.notifications.Failure = base.extends(ui.notifications.Notification, {
     init: function()
     {
-        this._time = this._how.appendChild(new ui.RelativeTime());
         this._problem = this._what.appendChild(document.createElement('div'));
         this._problem.className = 'problem';
         this._effects = this._problem.appendChild(document.createElement('ul'));
         this._effects.className = 'effects';
         this._causes = this._what.appendChild(document.createElement('ul'));
         this._causes.className = 'causes';
     },
-    date: function()
-    {
-        return this._time.date;
-    }
 });
 
 ui.notifications.FailingTests = base.extends(ui.notifications.Failure, {
     init: function() {
         // FIXME: Convert actions to a link from test!
         this._problem.appendChild(new ui.actions.List([
             new ui.actions.Examine().makeDefault(),
             new ui.actions.Rebaseline(),
         ]));
         this._testNameList = [];
@@ skipping 59 matching lines @@
         $(this._causes).children().each(function() {
             if (this.hasRevision(commitData.revision))
                 return;
             $(this).detach();
         });
     },
     addCommitData: function(commitData)
     {
         if (this._commitDataPinned)
             return null;
-        var commitDataDate = new Date(commitData.time);
-        if (this._time.date > commitDataDate); {

[ojan, 2014/06/14 18:42:11]

This looks like non-dead code, but we never call setDate on this._time, so
this._time.date is always undefined.

-            this.setIndex(commitDataDate.getTime());
-            this._time.setDate(commitDataDate);
-        }
         return this._causes.appendChild(new ui.notifications.SuspiciousCommit(commitData));
     }
 });
 
 ui.notifications.BuildersFailing = base.extends(ui.notifications.Failure, {
     init: function(message)
     {
         if (message)
             this._problem.insertBefore(document.createTextNode(message + ':'), this._problem.firstChild);
     },
     setFailingBuilders: function(failuresList)
     {
         $(this._effects).empty().append(Object.keys(failuresList).map(function(builderName) {
             var effect = document.createElement('li');
             effect.className = 'builder';
             effect.appendChild(new ui.failures.Builder(builderName, failuresList[builderName]));
             return effect;
         }));
     }
 });
 
 })();