Cleanup some garden-o-matic cruft and dead code.

Tools/GardeningServer/scripts/controllers.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 294 matching lines @@
     },
     onRollout: function(revision, testNameList)
     {
         checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList)).then($.noop, function() {
             // FIXME: We should have a better error UI.
             alert(kCheckoutUnavailableMessage);
         });
     }
 });
 
-controllers.Failures = base.extends(FailureStreamController, {

[ojan, 2014/06/14 18:42:11]

Dead code.

-    _resultsFilter: results.expectedFailuresByTest,
-
-    _keyFor: function(failureAnalysis)
-    {
-        return base.dirName(failureAnalysis.testName);
-    },
-    _createFailureView: function(failureAnalysis)
-    {
-        return new ui.notifications.FailingTests();
-    },
-});
-
 controllers.FailingBuilders = base.extends(Object, {
     init: function(view, message)
     {
         this._view = view;
         this._message = message;
         this._notification = null;
     },
     hasFailures: function()
     {
         return !!this._notification;
@@ skipping 11 matching lines @@
             this._notification = new ui.notifications.BuildersFailing(this._message);
             this._view.add(this._notification);
         }
         // FIXME: We should provide regression ranges for the failing builders.
         // This doesn't seem to happen often enough to worry too much about that, however.
         this._notification.setFailingBuilders(failuresList);
     }
 });
 
 })();