Cleanup some garden-o-matic cruft and dead code.

Cleanup some garden-o-matic cruft and dead code.

The biggest change is removing RelativeTime. We were creating these,
but not doing anything with them. These were also the only
things that ever called setIndex on Notification, so we can remove
index/setIndex from Notification.

The rest of the patch is just removing dead code.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176156

[ojan, 2014-06-14 18:42:11]

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/config.js (left):

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/config.js:31: kBuildNumberLimit: 20,
This was only used in a warning, but it was wrong because the warning implied it
actually used this number.

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/config.js:38: kSvnLogURL:
'http://build.chromium.org/cgi-bin/svn-log',
These two are unused.

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/controllers.js (left):

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/controllers.js:315: controllers.Failures =
base.extends(FailureStreamController, {
Dead code.

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/garden-o-matic.js (left):

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/garden-o-matic.js:71: var gtestIframe =
document.querySelector('#chromium-gtests iframe');
We never create this iframe.

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/ui/notifications.js (left):

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/ui/notifications.js:250: if (this._time.date >
commitDataDate); {
This looks like non-dead code, but we never call setDate on this._time, so
this._time.date is always undefined.

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
File Tools/GardeningServer/scripts/ui/notifications.js (right):

https://codereview.chromium.org/336033002/diff/1/Tools/GardeningServer/script...
Tools/GardeningServer/scripts/ui/notifications.js:40:
this.appendChild(notification);
Now that Notification doesn't have index, we would never set insertBefore here.

[abarth-chromium, 2014-06-14 19:19:35]

LGTM

[ojan, 2014-06-14 19:32:42]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-06-14 19:33:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/336033002/1

[commit-bot: I haz the power, 2014-06-14 19:34:15]

Change committed as 176156