Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: dart/pkg/polymer/lib/transformer.dart

Issue 336013003: Version 1.5.0-dev.4.14 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/pkg/polymer/lib/src/loader.dart ('k') | dart/pkg/polymer/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/polymer/lib/transformer.dart
===================================================================
--- dart/pkg/polymer/lib/transformer.dart (revision 37358)
+++ dart/pkg/polymer/lib/transformer.dart (working copy)
@@ -39,11 +39,13 @@
bool releaseMode = settings.mode == BarbackMode.RELEASE;
bool jsOption = args['js'];
bool csp = args['csp'] == true; // defaults to false
+ bool lint = args['lint'] != false; // defaults to true
return new TransformOptions(
entryPoints: _readEntrypoints(args['entry_points']),
directlyIncludeJS: jsOption == null ? releaseMode : jsOption,
contentSecurityPolicy: csp,
- releaseMode: releaseMode);
+ releaseMode: releaseMode,
+ lint: lint);
}
_readEntrypoints(value) {
@@ -71,6 +73,9 @@
/// is actually imported.
List<List<Transformer>> createDeployPhases(
TransformOptions options, {String sdkDir}) {
+ // TODO(sigmund): this should be done differently. We should lint everything
+ // that is reachable and have the option to lint the rest (similar to how
+ // dart2js can analyze reachable code or entire libraries).
var phases = options.lint ? [[new Linter(options)]] : [];
return phases..addAll([
[new ImportInliner(options)],
« no previous file with comments | « dart/pkg/polymer/lib/src/loader.dart ('k') | dart/pkg/polymer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698