Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: dart/pkg/template_binding/lib/src/input_bindings.dart

Issue 336013003: Version 1.5.0-dev.4.14 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/template_binding/lib/src/input_bindings.dart
===================================================================
--- dart/pkg/template_binding/lib/src/input_bindings.dart (revision 37358)
+++ dart/pkg/template_binding/lib/src/input_bindings.dart (working copy)
@@ -107,9 +107,12 @@
case 'select-multiple':
case 'select-one':
return element.onChange;
- default:
- return element.onInput;
+ case 'range':
+ if (window.navigator.userAgent.contains(new RegExp('Trident|MSIE'))) {
+ return element.onChange;
+ }
}
+ return element.onInput;
}
// |element| is assumed to be an HTMLInputElement with |type| == 'radio'.
@@ -148,3 +151,17 @@
return value is int ? value : 0;
}
}
+
+_getTreeScope(Node node) {
+ Node parent;
+ while ((parent = node.parentNode) != null ) {
+ node = parent;
+ }
+
+ return _hasGetElementById(node) ? node : null;
+}
+
+// Note: JS code tests that getElementById is present. We can't do that
+// easily, so instead check for the types known to implement it.
+bool _hasGetElementById(Node node) =>
+ node is Document || node is ShadowRoot || node is SvgSvgElement;
« no previous file with comments | « dart/pkg/template_binding/lib/src/element.dart ('k') | dart/pkg/template_binding/lib/src/input_element.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698