Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

Issue 336001: [Mac] Make bookmark bar a primitive drag destination. (Closed)
Patch Set: cleanup Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
diff --git a/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm b/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
index 985e96fc3014d488c45f4d16e9874a33b46cd022..11dc3fdac9c7f4ca4394bd65e5440ee734de3b60 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
+++ b/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm
@@ -6,6 +6,7 @@
#include "base/basictypes.h"
#include "base/scoped_nsobject.h"
+#include "base/sys_string_conversions.h"
#import "chrome/browser/cocoa/bookmark_bar_constants.h"
#import "chrome/browser/cocoa/bookmark_bar_controller.h"
#import "chrome/browser/cocoa/bookmark_bar_view.h"
@@ -669,6 +670,37 @@ TEST_F(BookmarkBarControllerTest, BookmarkButtonSizing) {
}
}
+TEST_F(BookmarkBarControllerTest, DropBookmarks) {
+ const char* urls[] = {
+ "http://qwantz.com",
+ "http://xkcd.com",
+ "javascript:alert('lolwut')"
+ };
+ std::wstring titles[] = {
+ std::wstring(L"Philosophoraptor"),
+ std::wstring(L"Can't draw"),
+ std::wstring(L"Inspiration")
+ };
+ EXPECT_EQ(arraysize(urls), arraysize(titles));
+
+ NSMutableArray* nsurls = [NSMutableArray arrayWithCapacity:0];
+ NSMutableArray* nstitles = [NSMutableArray arrayWithCapacity:0];
+ for (size_t i = 0; i < arraysize(urls); ++i) {
+ [nsurls addObject:[NSString stringWithCString:urls[i]]];
+ [nstitles addObject:base::SysWideToNSString(titles[i])];
+ }
+
+ BookmarkModel* model = helper_.profile()->GetBookmarkModel();
+ const BookmarkNode* parent = model->GetBookmarkBarNode();
+ [bar_ addURLs:nsurls withTitles:nstitles at:NSZeroPoint];
+ EXPECT_EQ(3, parent->GetChildCount());
+ for (int i = 0; i < parent->GetChildCount(); ++i) {
+ EXPECT_EQ(parent->GetChild(i)->GetURL(), GURL(urls[i]));
+ EXPECT_EQ(parent->GetChild(i)->GetTitle(), titles[i]);
+ }
+}
+
+
// Cannot test these methods since they simply call a single static
// method, BookmarkEditor::Show(), which is impossible to mock.
// editBookmark:, addPage:

Powered by Google App Engine
This is Rietveld 408576698