[Mac] Make bookmark bar a primitive drag destination.

chrome/browser/cocoa/bookmark_bar_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/l10n_util_mac.h"
 #include "app/resource_bundle.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_editor.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
@@ skipping 62 matching lines @@
     tabObserver_.reset(
         new TabStripModelObserverBridge(browser_->tabstrip_model(), self));
 
     ResourceBundle& rb = ResourceBundle::GetSharedInstance();
     folderImage_.reset([rb.GetNSImageNamed(IDR_BOOKMARK_BAR_FOLDER) retain]);
   }
   return self;
 }
 
 - (void)dealloc {
+  // Remove our view from its superview so it doesn't attempt to reference

[pink (ping after 24hrs), 2009/10/27 15:00:43]

is this necessary with dmac's changes, or just a hack until then?

[Nico, 2009/10/27 15:52:42]

See http://codereview.chromium.org/334029 .

+  // it when the controller is gone.
+  [[self view] removeFromSuperview];
   bridge_.reset(NULL);
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super dealloc];
 }
 
 - (void)awakeFromNib {
   // We default to NOT open, which means height=0.
   DCHECK([[self view] isHidden]);  // Hidden so it's OK to change.
 
   // Set our initial height to zero, since that is what the superview
@@ skipping 102 matching lines @@
 - (BOOL)isNewTabPage {
   return browser_ && browser_->GetSelectedTabContents() &&
       browser_->GetSelectedTabContents()->ShouldShowBookmarkBar();
 }
 
 - (BOOL)isAlwaysVisible {
   return browser_ &&
       browser_->profile()->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);
 }
 
+- (BOOL)addURLs:(NSArray*)urls withTitles:(NSArray*)titles at:(NSPoint)point {
+  // TODO(jrg): Support drops on folders etc
+  // TODO(jrg): Use |point|.
+  DCHECK([urls count] == [titles count]);
+  const BookmarkNode* node = bookmarkModel_->GetBookmarkBarNode();
+
+  for (size_t i = 0; i < [urls count]; ++i) {
+    bookmarkModel_->AddURL(
+        node,
+        node->GetChildCount(),
+        base::SysNSStringToWide([titles objectAtIndex:i]),
+        GURL([[urls objectAtIndex:i] UTF8String]));
+  }
+  return YES;
+}
+
 - (int)currentTabContentsHeight {
   return browser_->GetSelectedTabContents()->view()->GetContainerSize().
       height();
 }
 
 - (ThemeProvider*)themeProvider {
   return browser_->profile()->GetThemeProvider();
 }
 
 - (BOOL)drawAsFloatingBar {
@@ skipping 525 matching lines @@
 
 - (void)setUrlDelegate:(id<BookmarkURLOpener>)urlDelegate {
   urlDelegate_ = urlDelegate;
 }
 
 - (NSArray*)buttons {
   return buttons_.get();
 }
 
 @end