Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issue 335993006: PDF: Fix navigation for links that are just relative fragments. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

PDF: Fix navigation for links that are just relative fragments. BUG=389333 TEST=Manual, see bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283268

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M pdf/instance.cc View 2 chunks +16 lines, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
So can we have PDFs that link to file:// URLs?
6 years, 5 months ago (2014-06-26 23:37:20 UTC) #1
Lei Zhang
ping
6 years, 5 months ago (2014-07-11 01:50:54 UTC) #2
Lei Zhang
The original intention was to prevent javascript: links from working.
6 years, 5 months ago (2014-07-12 02:20:33 UTC) #3
jam
lgtm
6 years, 5 months ago (2014-07-15 00:31:57 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-15 00:37:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/335993006/60001
6 years, 5 months ago (2014-07-15 00:44:08 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 23:15:37 UTC) #7
Message was sent while issue was closed.
Change committed as 283268

Powered by Google App Engine
This is Rietveld 408576698