Issue 335973002: Minor Fixes for Windows GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335973002: Minor Fixes for Windows GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -10 lines)			Patch
M	BUILD.gn	View	1	3 chunks	+1 line, -2 lines	0 comments	Download
M	content/browser/BUILD.gn	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	content/ppapi_plugin/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	courgette/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/yasm/BUILD.gn	View		4 chunks	+14 lines, -5 lines	0 comments	Download
M	tools/gn/secondary/third_party/angle/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/third_party/nss/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

brettw

6 years, 6 months ago (2014-06-14 20:35:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r277272 (presubmit successful).