Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335963004: DevTools: Instrument GenericEventQueue for async stacks. (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Instrument GenericEventQueue for async stacks. This adds async stacks support for the following DOM events: - audio & video events (play, pause, ratechange, etc.) - TrackList events: addtrack, removetrack - MediaSource events (sourceopen and etc.) - autocomplete and others BUG=272416 R=yurys, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176523

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M LayoutTests/inspector/sources/debugger/async-callstack-events.html View 2 chunks +15 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-events-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/events/GenericEventQueue.cpp View 1 5 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
aandrey
6 years, 6 months ago (2014-06-19 12:49:09 UTC) #1
yurys
lgtm https://codereview.chromium.org/335963004/diff/1/Source/core/events/GenericEventQueue.cpp File Source/core/events/GenericEventQueue.cpp (right): https://codereview.chromium.org/335963004/diff/1/Source/core/events/GenericEventQueue.cpp#newcode125 Source/core/events/GenericEventQueue.cpp:125: EventTarget* target = event->target() ? event->target() : m_owner.get(); ...
6 years, 6 months ago (2014-06-19 13:26:45 UTC) #2
aandrey
https://codereview.chromium.org/335963004/diff/1/Source/core/events/GenericEventQueue.cpp File Source/core/events/GenericEventQueue.cpp (right): https://codereview.chromium.org/335963004/diff/1/Source/core/events/GenericEventQueue.cpp#newcode125 Source/core/events/GenericEventQueue.cpp:125: EventTarget* target = event->target() ? event->target() : m_owner.get(); On ...
6 years, 6 months ago (2014-06-19 14:16:20 UTC) #3
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-19 14:17:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/335963004/20001
6 years, 6 months ago (2014-06-19 14:18:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 15:55:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19233)
6 years, 6 months ago (2014-06-19 15:55:09 UTC) #7
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-19 16:11:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/335963004/20001
6 years, 6 months ago (2014-06-19 16:12:02 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 16:24:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 176523

Powered by Google App Engine
This is Rietveld 408576698