Change LayoutState to be stack-allocated

Source/core/rendering/RenderView.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2006 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 108 matching lines @@
         ASSERT(!RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
         if (!m_layoutState)
             return false;
         return (delta.width() == m_layoutState->layoutDelta().width() || m_layoutState->layoutDeltaXSaturated()) && (delta.height() == m_layoutState->layoutDelta().height() || m_layoutState->layoutDeltaYSaturated());
     }
 #endif
 
     bool shouldDoFullRepaintForNextLayout() const;
     bool doingFullRepaint() const { return m_frameView->needsFullPaintInvalidation(); }
 
-    // Subtree push
-    void pushLayoutState(RenderObject&);
+    // Returns true if layoutState should be used for its cached offset and clip.
+    bool layoutStateCachedOffsetsEnabled() const { return m_layoutState && m_layoutState->cachedOffsetsEnabled(); }
+    LayoutState* layoutState() const { return m_layoutState; }
+    void setLayoutState(LayoutState* layoutState) { m_layoutState = layoutState; }
 
-    void popLayoutState()
-    {
-        LayoutState* state = m_layoutState;
-        m_layoutState = state->next();
-        delete state;
-        popLayoutStateForCurrentFlowThread();
-    }
-
-    bool shouldDisableLayoutStateForSubtree(RenderObject&) const;
-
-    // Returns true if layoutState should be used for its cached offset and clip.
-    bool layoutStateEnabled() const { return m_layoutStateDisableCount == 0 && m_layoutState; }
-    LayoutState* layoutState() const { return m_layoutState; }
-
-    bool canUseLayoutStateForContainer(const RenderObject* repaintContainer) const
+    bool canMapUsingLayoutStateForContainer(const RenderObject* repaintContainer) const
     {
         // FIXME: LayoutState should be enabled for other repaint containers than the RenderView. crbug.com/363834
-        return layoutStateEnabled() && (repaintContainer == this);
+        return layoutStateCachedOffsetsEnabled() && (repaintContainer == this);
     }
 
     virtual void updateHitTestResult(HitTestResult&, const LayoutPoint&) OVERRIDE;
 
     LayoutUnit pageLogicalHeight() const { return m_pageLogicalHeight; }
     void setPageLogicalHeight(LayoutUnit height)
     {
         if (m_pageLogicalHeight != height) {
             m_pageLogicalHeight = height;
             m_pageLogicalHeightChanged = true;
@@ skipping 28 matching lines @@
     // rewrite the counter and quotes code.
     void addRenderCounter() { m_renderCounterCount++; }
     void removeRenderCounter() { ASSERT(m_renderCounterCount > 0); m_renderCounterCount--; }
     bool hasRenderCounters() { return m_renderCounterCount; }
 
     virtual bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect) const OVERRIDE;
 
     double layoutViewportWidth() const;
     double layoutViewportHeight() const;
 
-    // Suspends the LayoutState optimization. Used under transforms that cannot be represented by
-    // LayoutState (common in SVG) and when manipulating the render tree during layout in ways
-    // that can trigger repaint of a non-child (e.g. when a list item moves its list marker around).
-    // Note that even when disabled, LayoutState is still used to store layoutDelta.
-    // These functions may only be accessed by LayoutStateMaintainer or LayoutStateDisabler.
-    void disableLayoutState() { m_layoutStateDisableCount++; }
-    void enableLayoutState() { ASSERT(m_layoutStateDisableCount > 0); m_layoutStateDisableCount--; }
-
+    void pushLayoutState(LayoutState&);
+    void popLayoutState();
 private:
     virtual void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = 0) const OVERRIDE;
     virtual const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const OVERRIDE;
     virtual void mapAbsoluteToLocalPoint(MapCoordinatesFlags, TransformState&) const OVERRIDE;
     virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const OVERRIDE;
 
     virtual void invalidateTreeAfterLayout(const RenderLayerModelObject& paintInvalidationContainer) OVERRIDE FINAL;
 
     bool shouldRepaint(const LayoutRect&) const;
 
     bool rootFillsViewportBackground(RenderBox* rootBox) const;
 
-    // These functions may only be accessed by LayoutStateMaintainer.
-    bool pushLayoutState(RenderBox& renderer, const LayoutSize& offset, LayoutUnit pageHeight = 0, bool pageHeightChanged = false, ColumnInfo* colInfo = 0)
-    {
-        // We push LayoutState even if layoutState is disabled because it stores layoutDelta too.
-        if ((!doingFullRepaint() || (RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && layoutStateEnabled())) || m_layoutState->isPaginated() || renderer.hasColumns() || renderer.flowThreadContainingBlock()
-            ) {
-            pushLayoutStateForCurrentFlowThread(renderer);
-            m_layoutState = new LayoutState(m_layoutState, renderer, offset, pageHeight, pageHeightChanged, colInfo);
-            return true;
-        }
-        return false;
-    }
-
     void layoutContent();
 #ifndef NDEBUG
     void checkLayoutState();
 #endif
 
     void positionDialog(RenderBox*);
     void positionDialogs();
 
-    void pushLayoutStateForCurrentFlowThread(const RenderObject&);
-    void popLayoutStateForCurrentFlowThread();
-
-    friend class LayoutStateMaintainer;
     friend class ForceHorriblySlowRectMapping;
-    friend class RootLayoutStateScope;
 
     bool shouldUsePrintingLayout() const;
 
     RenderObject* backgroundRenderer() const;
 
     FrameView* m_frameView;
 
     RenderObject* m_selectionStart;
     RenderObject* m_selectionEnd;
 
     int m_selectionStartPos;
     int m_selectionEndPos;
 
     LayoutUnit m_pageLogicalHeight;
     bool m_pageLogicalHeightChanged;
     LayoutState* m_layoutState;
-    unsigned m_layoutStateDisableCount;
     OwnPtr<RenderLayerCompositor> m_compositor;
     OwnPtr<FlowThreadController> m_flowThreadController;
     RefPtr<IntervalArena> m_intervalArena;
 
     RenderQuote* m_renderQuoteHead;
     unsigned m_renderCounterCount;
 };
 
 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderView, isRenderView());
 
-class RootLayoutStateScope {
-public:
-    explicit RootLayoutStateScope(RenderObject& obj)
-        : m_view(*obj.view())
-        , m_rootLayoutState(m_view.pageLogicalHeight(), m_view.pageLogicalHeightChanged())
-        , m_isRenderView(obj.isRenderView())
-    {
-        // If the invalidation root isn't the renderView we have to make sure it
-        // gets added correctly to LayoutState otherwise we'll lose the margins that
-        // are set in the ancestors of the roots.
-        if (m_isRenderView) {
-            ASSERT(!m_view.m_layoutState);
-            m_view.m_layoutState = &m_rootLayoutState;
-        } else {
-            m_view.pushLayoutState(obj);
-        }
-    }
-
-    ~RootLayoutStateScope()
-    {
-        if (m_isRenderView) {
-            ASSERT(m_view.m_layoutState == &m_rootLayoutState);
-            m_view.m_layoutState = 0;
-        } else {
-            m_view.popLayoutState();
-        }
-    }
-private:
-    RenderView& m_view;
-    LayoutState m_rootLayoutState;
-    bool m_isRenderView;
-};
-
-// Stack-based class to assist with LayoutState push/pop
-class LayoutStateMaintainer {
-    WTF_MAKE_NONCOPYABLE(LayoutStateMaintainer);
-public:
-    // ctor to push now
-    explicit LayoutStateMaintainer(RenderBox& root, const LayoutSize& offset, LayoutUnit pageHeight = 0, bool pageHeightChanged = false, ColumnInfo* colInfo = 0)
-        : m_view(*root.view())
-        , m_disabled(root.shouldDisableLayoutState())
-        , m_didStart(false)
-        , m_didEnd(false)
-        , m_didCreateLayoutState(false)
-    {
-        push(root, offset, pageHeight, pageHeightChanged, colInfo);
-    }
-
-    // ctor to maybe push later
-    explicit LayoutStateMaintainer(RenderBox& root)
-        : m_view(*root.view())
-        , m_disabled(false)
-        , m_didStart(false)
-        , m_didEnd(false)
-        , m_didCreateLayoutState(false)
-    {
-    }
-
-    ~LayoutStateMaintainer()
-    {
-        if (m_didStart)
-            pop();
-        ASSERT(m_didStart == m_didEnd);   // if this fires, it means that someone did a push(), but forgot to pop().
-    }
-
-    void push(RenderBox& root, const LayoutSize& offset, LayoutUnit pageHeight = 0, bool pageHeightChanged = false, ColumnInfo* colInfo = 0)
-    {
-        ASSERT(!m_didStart);
-        // We push state even if disabled, because we still need to store layoutDelta
-        m_didCreateLayoutState = m_view.pushLayoutState(root, offset, pageHeight, pageHeightChanged, colInfo);
-        if (m_disabled && m_didCreateLayoutState)
-            m_view.disableLayoutState();
-        m_didStart = true;
-    }
-
-    bool didPush() const { return m_didStart; }
-
-private:
-    void pop()
-    {
-        ASSERT(m_didStart && !m_didEnd);
-        if (m_didCreateLayoutState) {
-            m_view.popLayoutState();
-            if (m_disabled)
-                m_view.enableLayoutState();
-        }
-
-        m_didEnd = true;
-    }
-
-    RenderView& m_view;
-    bool m_disabled : 1;        // true if the offset and clip part of layoutState is disabled
-    bool m_didStart : 1;        // true if we did a push or disable
-    bool m_didEnd : 1;          // true if we popped or re-enabled
-    bool m_didCreateLayoutState : 1; // true if we actually made a layout state.
-};
-
+// Suspends the LayoutState cached offset and clipRect optimization. Used under transforms
+// that cannot be represented by LayoutState (common in SVG) and when manipulating the render
+// tree during layout in ways that can trigger repaint of a non-child (e.g. when a list item
+// moves its list marker around). Note that even when disabled, LayoutState is still used to
+// store layoutDelta.
 class ForceHorriblySlowRectMapping {
     WTF_MAKE_NONCOPYABLE(ForceHorriblySlowRectMapping);
 public:
     ForceHorriblySlowRectMapping(const RenderObject& root)
-        : m_view(*root.view())
+        : m_didDisable(false)

[esprehn, 2014/06/13 23:25:26]

m_didDisable(m_view.layoutState() &&
m_view.layoutState()->cachedOffsetsEnabled())

?

[leviw_travelin_and_unemployed, 2014/06/13 23:46:16]

Sure.

+        , m_view(*root.view())
     {
-        m_view.disableLayoutState();
+        if (m_view.layoutState()) {
+            m_didDisable = m_view.layoutState()->cachedOffsetsEnabled();

[esprehn, 2014/06/13 23:25:26]

Why does cachedOffsetEnabled map to m_didDisable?

+            m_view.layoutState()->m_cachedOffsetsEnabled = false;

[esprehn, 2014/06/13 23:25:26]

This is weird to reaching into the LayotuState with m_cachedOffsetsEnabled. 

+        }
+#if !ASSERT_DISABLED

[esprehn, 2014/06/13 23:25:26]

This can't land, abarth removed ASSERT_DISABLED. It's not #if ASSERT_ENABLED

+        m_layoutState = m_view.layoutState();
+#endif
     }
 
     ~ForceHorriblySlowRectMapping()
     {
-        m_view.enableLayoutState();
+        ASSERT(m_view.layoutState() == m_layoutState);
+        if (m_didDisable)
+            m_view.layoutState()->m_cachedOffsetsEnabled = true;

[esprehn, 2014/06/13 23:25:26]

So cachedOffsetsEnabled means layoutStateEnabled?

[leviw_travelin_and_unemployed, 2014/06/13 23:46:16]

Yes, but there is no more layoutStateEnabled. LayoutState is always "enabled,"
but LayoutState::cachedOffsetsEnabled is not always true.

     }
 private:
+    bool m_didDisable;
     RenderView& m_view;
+#if !ASSERT_DISABLED
+    LayoutState* m_layoutState;
+#endif
 };
 
 } // namespace WebCore
 
 #endif // RenderView_h