Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/resources/options/chromeos/accounts_options.html

Issue 335953002: Add UMA stats for user settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <div id="accountsPage" class="page" hidden> 1 <div id="accountsPage" class="page" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <h1 i18n-content="accountsPage"></h1> 3 <h1 i18n-content="accountsPage"></h1>
4 <div class="content-area"> 4 <div class="content-area">
5 <div class="option"> 5 <div class="option">
6 <div id="ownerOnlyWarning" hidden> 6 <div id="ownerOnlyWarning" hidden>
7 <span i18n-content="owner_only"></span> 7 <span i18n-content="owner_only"></span>
8 <span i18n-content="ownerUserId"></span> 8 <span i18n-content="ownerUserId"></span>
9 </div> 9 </div>
10 <table class="option-control-table"> 10 <table class="option-control-table">
11 <tr> 11 <tr>
12 <td class="option-name"> 12 <td class="option-name">
13 <div class="checkbox"> 13 <div class="checkbox">
14 <label> 14 <label>
15 <input id="allowBwsiCheck" pref="cros.accounts.allowBWSI" 15 <input id="allowBwsiCheck"
16 type="checkbox"> 16 metric="Options_EnableGuestBrowsing"
17 pref="cros.accounts.allowBWSI"
18 type="checkbox">
michaelpg 2014/06/13 23:15:43 nit: You could fit this and the ones below in 2-3
stevenjb 2014/06/16 21:58:10 I moved type next to id for brevity but I prefer t
17 <span i18n-content="allow_BWSI"></span> 19 <span i18n-content="allow_BWSI"></span>
18 </label> 20 </label>
19 </div> 21 </div>
20 </td> 22 </td>
21 </tr> 23 </tr>
22 <tr> 24 <tr>
23 <td class="option-name"> 25 <td class="option-name">
24 <div class="checkbox"> 26 <div class="checkbox">
25 <label> 27 <label>
26 <input id="allowSupervisedCheck" 28 <input id="allowSupervisedCheck"
27 pref="cros.accounts.supervisedUsersEnabled" type="checkbox"> 29 metric="Options_EnableSupervisedUsers"
30 pref="cros.accounts.supervisedUsersEnabled"
31 type="checkbox">
28 <span i18n-content="allow_supervised_users"></span> 32 <span i18n-content="allow_supervised_users"></span>
29 </label> 33 </label>
30 </div> 34 </div>
31 </td> 35 </td>
32 </tr> 36 </tr>
33 <tr> 37 <tr>
34 <td class="option-name"> 38 <td class="option-name">
35 <div class="checkbox"> 39 <div class="checkbox">
36 <label> 40 <label>
37 <input id="showUserNamesCheck" 41 <input id="showUserNamesCheck"
38 pref="cros.accounts.showUserNamesOnSignIn" type="checkbox"> 42 metric="Options_ShowUserNamesOnSignin"
43 pref="cros.accounts.showUserNamesOnSignIn"
44 type="checkbox">
39 <span i18n-content="show_user_on_signin"></span> 45 <span i18n-content="show_user_on_signin"></span>
40 </label> 46 </label>
41 </div> 47 </div>
42 </td> 48 </td>
43 </tr> 49 </tr>
44 <tr> 50 <tr>
45 <td class="option-name"> 51 <td class="option-name">
46 <div class="checkbox"> 52 <div class="checkbox">
47 <label> 53 <label>
48 <input id="useWhitelistCheck" pref="cros.accounts.allowGuest" 54 <input id="useWhitelistCheck"
49 type="checkbox" inverted_pref> 55 metric="Options_RestrictUsers"
56 pref="cros.accounts.allowGuest"
57 type="checkbox" inverted_pref>
michaelpg 2014/06/13 23:15:43 This is an inverted_pref, which changes the value
stevenjb 2014/06/16 21:58:10 Done.
50 <span i18n-content="use_whitelist"></span> 58 <span i18n-content="use_whitelist"></span>
51 </label> 59 </label>
52 </div> 60 </div>
53 </td> 61 </td>
54 </tr> 62 </tr>
55 <tr><td>&nbsp;</td></tr> 63 <tr><td>&nbsp;</td></tr>
56 <tr><td> 64 <tr><td>
57 <table class="user-list-table"> 65 <table class="user-list-table">
58 <tr><td> 66 <tr><td>
59 <list id="userList"></list> 67 <list id="userList"></list>
(...skipping 11 matching lines...) Expand all
71 </div> 79 </div>
72 </div> 80 </div>
73 <div class="action-area"> 81 <div class="action-area">
74 <div class="button-strip"> 82 <div class="button-strip">
75 <button id="accounts-options-overlay-confirm" class="default-button" 83 <button id="accounts-options-overlay-confirm" class="default-button"
76 i18n-content="done"> 84 i18n-content="done">
77 </button> 85 </button>
78 </div> 86 </div>
79 </div> 87 </div>
80 </div> 88 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698